-
Notifications
You must be signed in to change notification settings - Fork 64
Update mcad kuberay example #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mcad kuberay example #617
Conversation
@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: kevin85421. Note that only project-codeflare members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we want this tutorial to be based on ODH installation, but if it's the same markdown in both repos the helm install of kuberay is fine
Co-authored-by: Anish Asthana <[email protected]>
Co-authored-by: Kai-Hsun Chen <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
closes #583
What changes have been made
Verification steps
Follow the instruction in the modified
doc/usage/examples/kuberay/kuberay-mcad.md
fileChecks
This PR should be updated with the issue
/cc @anishasthana @kevin85421