Skip to content

Impr/logging #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 12, 2023
Merged

Impr/logging #1396

merged 11 commits into from
Apr 12, 2023

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Mar 20, 2023

Adds capability to log outputs for the WASM functions
This looks like:
image
image

closes #1390

@Druue Druue added this to the 4.12.0 milestone Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023 •
edited
Loading

🤖 Pull request artifacts

file commit
pr1396-prisma.vsix 96d1a38

github-actions bot added a commit that referenced this pull request Mar 20, 2023
@github-actions
Upload pr1396-prisma.vsix (1689d)
2756045 
Pull request: #1396
Commit: 1689da5
@github-actions
Copy link

Try this extension build via GitPod

@Druue Druue mentioned this pull request Mar 20, 2023
Closed
janpio
janpio reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this looks interesting.

Two things:

  1. The naming of onError/showErrorToast seems off to me. I left a comment in packages/language-server/src/util.ts that explains why I think that is.
  2. Can we test this somehow?

jkomyno
jkomyno requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes / replies to discussions are required, but you're on the right track

github-actions bot added a commit that referenced this pull request Mar 31, 2023
@github-actions
Upload pr1396-prisma.vsix (396b7)
b6685b3 
Pull request: #1396
Commit: 396b731
@Druue Druue modified the milestones: 4.12.0, 4.13.0 Mar 31, 2023
github-actions bot added a commit that referenced this pull request Mar 31, 2023
@github-actions
Upload pr1396-prisma.vsix (db624)
5667e6d 
Pull request: #1396
Commit: db62499
github-actions bot added a commit that referenced this pull request Apr 3, 2023
@github-actions
Upload pr1396-prisma.vsix (cf28b)
bf54bfc 
Pull request: #1396
Commit: cf28b64
Druue added 7 commits April 3, 2023 12:51
@Druue
wasm logging
2ab66d9
@Druue
added toasts for wasm-errors
f9ee787 
formatting
eslint
@Druue
remove unnecessary unused-var rules
37ca82e
@Druue
Updated naming scheme to use onError
d801e41 
The variant will use it's own name in `server.ts`
- to show what's being given, in this case `showErrorToast`
@Druue
added check to prisma-fmt fns for debug panic
3d85972
@Druue
Added tests for wasm-panics
057d85f 
Added missing onError for previews path
Minor Refactor
- Moved findCursorPosition
@Druue
explicit undefined check for
4798aef 
- compositeTypeFieldNames
github-actions bot added a commit that referenced this pull request Apr 3, 2023
@github-actions
Upload pr1396-prisma.vsix (e28f3)
879bf70 
Pull request: #1396
Commit: e28f38c
github-actions bot added a commit that referenced this pull request Apr 3, 2023
@github-actions
Upload pr1396-prisma.vsix (4798a)
b0f35be 
Pull request: #1396
Commit: 4798aef
@Druue
Added comment for mock onError
199e476 
Added check for arg getting used
github-actions bot added a commit that referenced this pull request Apr 3, 2023
@github-actions
Upload pr1396-prisma.vsix (199e4)
51028e7 
Pull request: #1396
Commit: 199e476
@Druue Druue requested a review from jkomyno April 4, 2023 09:16
github-actions bot added a commit that referenced this pull request Apr 12, 2023
@github-actions
Upload pr1396-prisma.vsix (50a63)
0917ca9 
Pull request: #1396
Commit: 50a6376
github-actions bot added a commit that referenced this pull request Apr 12, 2023
@github-actions
Upload pr1396-prisma.vsix (dcabc)
16c2ec4 
Pull request: #1396
Commit: dcabcbe
github-actions bot added a commit that referenced this pull request Apr 12, 2023
@github-actions
Upload pr1396-prisma.vsix (96d1a)
3314a16 
Pull request: #1396
Commit: 96d1a38
@Druue Druue merged commit ca129b4 into main Apr 12, 2023
@Druue Druue deleted the impr/logging branch April 12, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@jkomyno jkomyno jkomyno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.

[object Object] output in logging isn't helpful
3 participants
@Druue @janpio @jkomyno