added toasts for wasm-errors

formatting
eslint

Author: Druue

.eslintrc.js

@@ -22,7 +22,16 @@ module.exports = {
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended-requiring-type-checking',
       ],
-      rules: {},
+      rules: {
+        '@typescript-eslint/no-unused-vars': [
+          'warn', // or "error"
+          {
+            argsIgnorePattern: '^_',
+            varsIgnorePattern: '^_',
+            caughtErrorsIgnorePattern: '^_',
+          },
+        ],
+      },
     },
   ],
 }

packages/language-server/src/MessageHandler.ts

@@ -70,12 +70,12 @@ import { createDiagnosticsForIgnore } from './diagnosticsHandler'
 
 export function handleDiagnosticsRequest(
   document: TextDocument,
-  onError?: (errorMessage: string) => void,
+  showErrorToast?: (errorMessage: string) => void,
 ): Diagnostic[] {
   const text = document.getText(fullDocumentRange(document))
   const res = lint(text, (errorMessage: string) => {
-    if (onError) {
-      onError(errorMessage)
+    if (showErrorToast) {
+      showErrorToast(errorMessage)
     }
   })
 
@@ -87,8 +87,8 @@ export function handleDiagnosticsRequest(
         diagnostic.text === 'Model declarations have to be indicated with the `model` keyword.',
     )
   ) {
-    if (onError) {
-      onError(
+    if (showErrorToast) {
+      showErrorToast(
         "You might currently be viewing a Prisma 1 datamodel which is based on the GraphQL syntax. The current Prisma Language Server doesn't support this syntax. If you are handling a Prisma 1 datamodel, please change the file extension to `.graphql` so the new Prisma Language Server does not get triggered anymore.",
       )
     }
@@ -237,10 +237,18 @@ export function handleHoverRequest(document: TextDocument, params: HoverParams):
   return
 }
 
-function prismaFmtCompletions(params: CompletionParams, document: TextDocument): CompletionList | undefined {
+function prismaFmtCompletions(
+  params: CompletionParams,
+  document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
+): CompletionList | undefined {
   const text = document.getText(fullDocumentRange(document))
 
-  const completionList = textDocumentCompletion(text, params)
+  const completionList = textDocumentCompletion(text, params, (errorMessage: string) => {
+    if (showErrorToast) {
+      showErrorToast(errorMessage)
+    }
+  })
 
   if (completionList.items.length === 0) {
     return undefined
@@ -249,7 +257,11 @@ function prismaFmtCompletions(params: CompletionParams, document: TextDocument):
   }
 }
 
-function localCompletions(params: CompletionParams, document: TextDocument): CompletionList | undefined {
+function localCompletions(
+  params: CompletionParams,
+  document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
+): CompletionList | undefined {
   const context = params.context
   const position = params.position
 
@@ -291,6 +303,7 @@ function localCompletions(params: CompletionParams, document: TextDocument): Com
           lines,
           wordsBeforePosition,
           document,
+          showErrorToast,
         )
       case '"':
         return getSuggestionForSupportedFields(
@@ -303,13 +316,10 @@ function localCompletions(params: CompletionParams, document: TextDocument): Com
       case '.':
         // check if inside attribute
         // Useful to complete composite types
-        if (
-          ['model', 'view'].includes(foundBlock.type) &&
-          isInsideAttribute(currentLineUntrimmed, position, '()')
-        ) {
+        if (['model', 'view'].includes(foundBlock.type) && isInsideAttribute(currentLineUntrimmed, position, '()')) {
           return getSuggestionsForInsideRoundBrackets(currentLineUntrimmed, lines, document, position, foundBlock)
         } else {
-          return getSuggestionForNativeTypes(foundBlock, lines, wordsBeforePosition, document)
+          return getSuggestionForNativeTypes(foundBlock, lines, wordsBeforePosition, document, showErrorToast)
         }
     }
   }
@@ -326,7 +336,14 @@ function localCompletions(params: CompletionParams, document: TextDocument): Com
       if (!positionIsAfterFieldAndType(position, document, wordsBeforePosition)) {
         return getSuggestionsForFieldTypes(foundBlock, lines, position, currentLineUntrimmed)
       }
-      return getSuggestionForFieldAttribute(foundBlock, lines[position.line], lines, wordsBeforePosition, document)
+      return getSuggestionForFieldAttribute(
+        foundBlock,
+        lines[position.line],
+        lines,
+        wordsBeforePosition,
+        document,
+        showErrorToast,
+      )
     case 'datasource':
     case 'generator':
       if (wordsBeforePosition.length === 1 && symbolBeforePositionIsWhiteSpace) {
@@ -356,8 +373,12 @@ function localCompletions(params: CompletionParams, document: TextDocument): Com
  *
  * This handler provides the initial list of the completion items.
  */
-export function handleCompletionRequest(params: CompletionParams, document: TextDocument): CompletionList | undefined {
-  return prismaFmtCompletions(params, document) || localCompletions(params, document)
+export function handleCompletionRequest(
+  params: CompletionParams,
+  document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
+): CompletionList | undefined {
+  return prismaFmtCompletions(params, document, showErrorToast) || localCompletions(params, document, showErrorToast)
 }
 
 export function handleRenameRequest(params: RenameParams, document: TextDocument): WorkspaceEdit | undefined {
@@ -453,12 +474,16 @@ export function handleCompletionResolveRequest(item: CompletionItem): Completion
   return item
 }
 
-export function handleCodeActions(params: CodeActionParams, document: TextDocument): CodeAction[] {
+export function handleCodeActions(
+  params: CodeActionParams,
+  document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
+): CodeAction[] {
   if (!params.context.diagnostics.length) {
     return []
   }
 
-  return quickFix(document, params)
+  return quickFix(document, params, showErrorToast)
 }
 
 export function handleDocumentSymbol(params: DocumentSymbolParams, document: TextDocument): DocumentSymbol[] {

packages/language-server/src/codeActionProvider.ts

@@ -9,7 +9,7 @@ import {
 } from 'vscode-languageserver'
 import levenshtein from 'js-levenshtein'
 import { convertDocumentTextToTrimmedLineArray, getAllRelationNames } from './util'
-import { prismaFmt } from './wasm'
+import codeActions from './prisma-fmt/codeActions'
 
 function getInsertRange(document: TextDocument): Range {
   // to insert text into a document create a range where start === end.
@@ -81,19 +81,22 @@ function addTypeModifiers(hasTypeModifierArray: boolean, hasTypeModifierOptional
   return suggestion
 }
 
-export function quickFix(textDocument: TextDocument, params: CodeActionParams): CodeAction[] {
+export function quickFix(
+  textDocument: TextDocument,
+  params: CodeActionParams,
+  showErrorToast?: (errorMessage: string) => void,
+): CodeAction[] {
   const diagnostics: Diagnostic[] = params.context.diagnostics
 
   if (!diagnostics || diagnostics.length === 0) {
     return []
   }
 
-  // get code actions from prisma-fmt
-  const actionDataFromPrismaFmt: string = prismaFmt.code_actions(textDocument.getText(), JSON.stringify(params))
-  // For debugging
-  // console.log({ actionDataFromPrismaFmt })
-
-  const codeActions: CodeAction[] = JSON.parse(actionDataFromPrismaFmt) as CodeAction[]
+  const codeActionList = codeActions(textDocument.getText(), JSON.stringify(params), (errorMessage: string) => {
+    if (showErrorToast) {
+      showErrorToast(errorMessage)
+    }
+  })
 
   // Add code actions from typescript side
   for (const diag of diagnostics) {
@@ -109,7 +112,7 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
       const lines: string[] = convertDocumentTextToTrimmedLineArray(textDocument)
       const spellingSuggestion = getSpellingSuggestions(diagText, getAllRelationNames(lines))
       if (spellingSuggestion) {
-        codeActions.push({
+        codeActionList.push({
           title: `Change spelling to '${spellingSuggestion}'`,
           kind: CodeActionKind.QuickFix,
           diagnostics: [diag],
@@ -125,7 +128,7 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
           },
         })
       }
-      codeActions.push({
+      codeActionList.push({
         title: `Create new model '${diagText}'`,
         kind: CodeActionKind.QuickFix,
         diagnostics: [diag],
@@ -140,7 +143,7 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
           },
         },
       })
-      codeActions.push({
+      codeActionList.push({
         title: `Create new enum '${diagText}'`,
         kind: CodeActionKind.QuickFix,
         diagnostics: [diag],
@@ -159,7 +162,7 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
       diag.severity === DiagnosticSeverity.Warning &&
       diag.message.includes("property has been renamed to 'previewFeatures'")
     ) {
-      codeActions.push({
+      codeActionList.push({
         title: "Rename property to 'previewFeatures'",
         kind: CodeActionKind.QuickFix,
         diagnostics: [diag],
@@ -182,7 +185,7 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
       if (diagText.length !== 0) {
         const spellingSuggestion = getSpellingSuggestions(diagText[0], ['model', 'enum', 'datasource', 'generator'])
         if (spellingSuggestion) {
-          codeActions.push({
+          codeActionList.push({
             title: `Change spelling to '${spellingSuggestion}'`,
             kind: CodeActionKind.QuickFix,
             diagnostics: [diag],
@@ -209,5 +212,5 @@ export function quickFix(textDocument: TextDocument, params: CodeActionParams):
     }
   }
 
-  return codeActions
+  return codeActionList
 }

packages/language-server/src/completion/completionUtils.ts

@@ -121,6 +121,7 @@ export function givenBlockAttributeParams({
   blockAttribute,
   wordBeforePosition,
   datasourceProvider,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   previewFeatures,
 }: {
   blockAttribute: '@@unique' | '@@id' | '@@index' | '@@fulltext'
@@ -327,6 +328,7 @@ export const fieldAttributes: CompletionItem[] = convertAttributesToCompletionIt
 export const sortLengthProperties: CompletionItem[] =
   // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
   convertToCompletionItems(
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     completions.fieldAttributes
       .find((item) => item.label === '@unique')!
       .params.filter((item) => item.label === 'length' || item.label === 'sort'),
@@ -513,8 +515,16 @@ export function handlePreviewFeatures(
   }
 }
 
-export function getNativeTypes(document: TextDocument, prismaType: string): CompletionItem[] {
-  let nativeTypes: NativeTypeConstructors[] = nativeTypeConstructors(document.getText())
+export function getNativeTypes(
+  document: TextDocument,
+  prismaType: string,
+  showErrorToast?: (errorMessage: string) => void,
+): CompletionItem[] {
+  let nativeTypes: NativeTypeConstructors[] = nativeTypeConstructors(document.getText(), (errorMessage: string) => {
+    if (showErrorToast) {
+      showErrorToast(errorMessage)
+    }
+  })
 
   if (nativeTypes.length === 0) {
     console.log('Did not receive any native type suggestions from prisma-fmt call.')

packages/language-server/src/completion/completions.ts

@@ -117,8 +117,10 @@ export function getSuggestionForNativeTypes(
   lines: string[],
   wordsBeforePosition: string[],
   document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
 ): CompletionList | undefined {
-  const activeFeatureFlag = declaredNativeTypes(document)
+  const activeFeatureFlag = declaredNativeTypes(document, showErrorToast)
+
   if (
     // TODO type? native "@db." types?
     foundBlock.type !== 'model' ||
@@ -135,7 +137,7 @@ export function getSuggestionForNativeTypes(
 
   // line
   const prismaType = wordsBeforePosition[1].replace('?', '').replace('[]', '')
-  const suggestions = getNativeTypes(document, prismaType)
+  const suggestions = getNativeTypes(document, prismaType, showErrorToast)
 
   return {
     items: suggestions,
@@ -161,6 +163,7 @@ export function getSuggestionForFieldAttribute(
   lines: string[],
   wordsBeforePosition: string[],
   document: TextDocument,
+  showErrorToast?: (errorMessage: string) => void,
 ): CompletionList | undefined {
   const fieldType = getFieldType(currentLine)
   // If we don't find a field type (e.g. String, Int...), return no suggestion
@@ -174,7 +177,7 @@ export function getSuggestionForFieldAttribute(
   if (wordsBeforePosition.length >= 2) {
     const datasourceName = getFirstDatasourceName(lines)
     const prismaType = wordsBeforePosition[1]
-    const nativeTypeSuggestions = getNativeTypes(document, prismaType)
+    const nativeTypeSuggestions = getNativeTypes(document, prismaType, showErrorToast)
 
     if (datasourceName) {
       if (!currentLine.includes(`@${datasourceName}`)) {
@@ -822,6 +825,7 @@ function getSuggestionsForAttribute(
           let name = value
           // Example for `@@index([email,address.|])` when there is no space between fields
           if (name?.includes(',')) {
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             name = name.split(',').pop()!
           }
           // Remove . to only get the name

packages/language-server/src/prisma-fmt/codeActions.ts

@@ -0,0 +1,21 @@
+import { CodeAction } from 'vscode-languageserver'
+import { prismaFmt } from '../wasm'
+import { handleWasmError } from './util'
+
+export default function codeActions(
+  schema: string,
+  params: string,
+  onError?: (errorMessage: string) => void,
+): CodeAction[] {
+  try {
+    const result = prismaFmt.code_actions(schema, params)
+
+    return JSON.parse(result) as CodeAction[]
+  } catch (e) {
+    const err = e as Error
+
+    handleWasmError(err, 'code_actions', onError)
+
+    return []
+  }
+}