GumGum adapter

[davidmh]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

• test parameters for validating bids

{
  bidder: 'gumgum',
  params: {
    inScreen: 'tracking_id'
  }
  // More products will be incorporated in the future.
}

• contact email of the adapter’s maintainer
  [email protected]
• official adapter submission

[kwunchoy]

@matthewlane sorry to bother you but can help us get our PR reviewed?

[matthewlane]

Yes, I'll review this today. Thanks for your patience

[matthewlane]

Thanks for this adapter PR. I was able to validate bids, just a few notes for your review below

[matthewlane]

Is this line required for your tests? Overwriting the global data structures in tests can cause weird effects elsewhere. If this isn't needed please remove

[davidmh]

I don't think we need it. I was just trying to follow the convention used on other tests.

I'll remove it shortly.

[matthewlane]

Line 77 - 79 is hard for me to understand, can you clarify what's happening here? The rest of your code style looks great, if it's possible to apply that to this section and retain functionality, please do

[davidmh]

A lot of our creatives assume the GumGum script is running on top, so this function is intended to pass our winning bid to the entry point in our script (top.GUMGUGM.pbjs), but first, we need to be sure our script exists on top.

Here's the uncompressed script:

(function (request) {
    request( /* tracking id */ , /* productId */ , /* ad payload */ , /* iframed window */ , /* top window*/ );
})(function (trackingId, prodId, data, context, w, d, s, G) {
    G = w.GUMGUM;
    d = w.document;
    // load gumgum script
    function lg() {
        w.GUMGUM.pbjs(trackingId, prodId, data, context, this);
    }
    return !G
        // if the gumgum object doesn't exist on the top window, we need to load it
        // and then pass the payload
        ? w.$$PREBID_GLOBAL$$.loadScript("https://g2.gumgum.com/javascripts/ggv2.js", lg)
        // if the script is already running, just pass the payload
        : lg();
});

[davidmh]

@matthewlane do you need me to change the format?

[mkendall07]

@davidmh
Please include the unminified version in the adapter code. Thanks

[davidmh]

Done