Skip to content

AOL bidder support #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

AOL bidder support #67

wants to merge 5 commits into from

Conversation

ikhemissi
Copy link
Contributor

Hi guys,

I wanted to discuss the addition of support for AOL.

I think we can achieve that by either calling their REST API directly (more or less the way I did it here) or by using their Javascript library DAC.js (the way @nickjacob did it in this commit prebid/Prebid.js/commit/da753b8569696e2c0bff353b370be1753bde8883).

Each solution has its advantages and its drawbacks :

  • REST API call : the cost of performing the request bid is minimized but we have to understand how the API works (and we will perhaps lose some user data in the process).
  • DAC.js : we have to load more resources (dependencies) in order to request the bid but less knowledge of the library/API is required in order to perform the bid request.

What do you think ?

@ikhemissi ikhemissi mentioned this pull request Oct 14, 2015
Merged
@mkendall07
Copy link
Member

Hi @ikhemissi ,
Thanks for the contribution. Can you explain more about possible loss of user data in process when using the REST API?

@ikhemissi
Copy link
Contributor Author

Hi @mkendall07 ,
I was thinking about extra data that may (or not) be passed by DAC.js to the API like latitude and longitude.
With this implementation, we still can pass such data using the optional parameter "params.options" (a javascript object) but we have to do it ourselves. I mean searching for extra data and passing it to the bid configuration.
Whereas with DAC.js and its dependencies, this have been taken into account and it should be filled automatically.
This being said, I didn't confirm this myself so I can't be sure if this information is well handled or not by DAC.js.
On the other side, I think that not having all these extra dependencies may lead - depending on the type of site - to faster bids and faster page display.

@nickjacob
Copy link
Collaborator

I was thinking of going this route but got turned off by having to gather referrer (as AOL defines it) + other user data that they want (I think they do get a geo, I can get relevant code from DAC). DAC + the pubAPI script (loaded by DAC) will add user data by default if you don't specify any

I like this approach for speed/lightweight but I'm worried that it could hurt CPM by limiting AOL's access to impression context? my other concern would just be that aol would be turned off/have more friction if they don't see DAC.js (during integration)

@nickjacob
Copy link
Collaborator

ok actually just answered my own question + realized we might want to either enable all of this for the adapter or add to bid params:

you can enable/disable option to detect screen, flash version, timezone & geo (using html5 geo api if available) through DAC, right now it's all disabled in the other AOL adapter, going to check with our rep to see if it's something we should be doing -- here's screenshot of some of the DAC code --

screen shot 2015-10-14 at 3 45 34 pm

it might be there just for adtech server in which case I don't think DAC brings as much benefit

@mkendall07
Copy link
Member

Thanks @ikhemissi and @nickjacob for the info. As a publisher AOL advices to use DAC, then I think that would be the preferred way to go. It may not be a good idea to tightly couple to the API directly, in case changes are made. I'll wait for confirmation from @nickjacob on AOL's preference here.

@mkendall07
Copy link
Member

Hey @nickjacob any more thoughts on this?

@nickjacob
Copy link
Collaborator

Had a meeting w/ Wenda Zhou @aol yesterday; he's the product lead on marketplace client-side—hopefully he/his team will be contributing soon. They're recommending using DAC for now, since they'll be rolling out changes in the future to better support prebid.

@ikhemissi
Copy link
Contributor Author

Hi guys,

I have ended up using the DAC.js solution too.
Can you please check the pull-request #85 to prepare for a merge with the master branch ?

@mkendall07
Copy link
Member

AOL already added with this PR: #55

@mkendall07 mkendall07 closed this Nov 2, 2015
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
@vzhukovsky
Merge pull request prebid#67 in AOLP_ADS_JS/prebid.js from release/1.…
7d144bb 
…10.0 to master

* commit 'b39f2b12a8ddfa650a8e04e3abd358e60371950a':
  Add changelog entry.
  Add new adapters for AOL analytics.
  Updated Prebid version
  Catch cross-origin DOMException (prebid#861)
  Add GumGum adapter (prebid#833)
  Remove duplicate log line in request bids (prebid#859)
  Utility function getBidIdParamater is misspelled
  Allow Conversant sizes to be overridden per placement (prebid#816)
  Add districtmDMX adapter (prebid#811)
  Truncate bids requested on clearPlacements (prebid#825) (prebid#828)
  Update adapters.json (prebid#803)
  Add usersyncing to AppNexus adapters (prebid#845)
  fixes for bugs in test suite (prebid#810)
  Pass user object parameters on bid request (prebid#821)
  fix rubicon deals to be per ad instead of per response (prebid#838)
  Links bidId in request with adId in response for analytics purposes (prebid#836)
  Bugfix/issue building from npm (prebid#823)
  Update build to only run `webpack` to improve build time performance (prebid#809)
  Cast all Conversant site_ids to a string (prebid#829)
  Increment pre version
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikhemissi @mkendall07 @nickjacob