Sovrn adapter updates: schain, digitrust, pixel syncing, and 3.0 upgrades #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Sovrn Master
|
addressing backwards-compatibility issue discussed on #4376. still not sure if anything has to change with pixel syncing implementation? |
aprakash-sovrn
changed the title
| expect(returnStatement).to.be.empty; | ||
| }); | ||
|
|
||
| it.only('should include pixel syncs', () => { |
There was a problem hiding this comment.
This should be reverted to it(...
There was a problem hiding this comment.
good catch, sorry about that
jsnellbaker
requested changes
Nov 7, 2019
modules/sovrnBidAdapter.js
Outdated
Comment on lines
63
to
65
| const el = document.createElement('a'); | ||
| el.href = page; | ||
| const domain = el.hostname; |
There was a problem hiding this comment.
Instead of doing this (which isn't really ideal), can you use the parse function from the url.js file to read the page variable; it'll provide the hostname in the returned object.
| @@ -73,7 +76,7 @@ describe('sovrnBidAdapter', function() { | |||
| expect(payload.imp[0].banner.h).to.equal(1) | |||
| }) | |||
|
|
|||
| it('accepts a single array as a size', function() { | |||
| it('accepts a single array as a size', () => { | |||
There was a problem hiding this comment.
Can you please change this back to function() { here (and in other parts of the test file)? We want to keep it this style to better conform for Mocha.
aprakash-sovrn
force-pushed
the
many_sneks_schain_digitrust_pixel-beacons
branch
from
3b2e522 to
5cab28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Sovrn bid adapter changes:
Added forwarding of schain and digitrust ID's to bid request
Supporting pixel syncing fro bid responses
Prebid.js 3.0 compliance updates
contact email of the adapter’s maintainer: [email protected]
official adapter submission