Skip to content

Revert "Sovrn adapter updates: schain, digitrust, pixel syncing, and 3.0 upgrades" #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

msm0504
Copy link
Contributor

@msm0504 msm0504 commented Oct 24, 2019

Reverts #4335

@aprakash-sovrn,
Your changes do not work with the latest Prebid. pixelEnabled has been deprecated.
Please merge the latest Prebid master into your fork and fix this issue before opening a new PR for these changes.

@msm0504 msm0504 requested a review from jsnellbaker October 24, 2019 18:41
@jsnellbaker
Copy link
Collaborator

@aprakash-sovrn To clarify the above a bit further, the pixelEnabled field for the spec.getUserSyncs() has not been deprecated on master. It will eventually be deprecated from the public API for userSync, but even then - the structure of the syncOptions field for the spec.getUserSyncs() should remain the same.

That said - since #4335 has been merged, (at least) one of the sovrn unit tests has been consistently failing across several browsers (namely Safari, Edge, and IE).

Below is a copy of the circleci test that showed the test failures for reference:
https://circleci.com/gh/prebid/Prebid.js/4492

Can you please investigate, recreate the PR with the updates to address this issue? We're going to revert the PR for the time being.

@jsnellbaker jsnellbaker merged commit ea2fc95 into master Oct 24, 2019
@msm0504
Copy link
Contributor Author

msm0504 commented Oct 24, 2019

@aprakash-sovrn It's possible that using flatMap was causing the tests to fail. That function is not supported in IE, Edge, or Safari < v12.

Please try replacing that function on line 175 of your adapter. An alternative is specified at the bottom of the flatMap doc: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap

@aprakash-sovrn
Copy link
Contributor

aprakash-sovrn commented Oct 25, 2019

is pixel syncing being removed entirely from Prebid? or does it just need to happen in a different way now?
@msm0504 @jsnellbaker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants