Skip to content

add console message when number of adunits exceeds point #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2019
Merged

add console message when number of adunits exceeds point #3707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05950c
add console message when number of adunits exceeds point
jsnellbaker Apr 3, 2019
58369a5
include additional information in log message
jsnellbaker Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/prebid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ function setRenderSize(doc, width, height) {
}

export const checkAdUnitSetup = hook('sync', function (adUnits) {
let adUnitsLen = adUnits.length;
if (adUnitsLen > 15) {
utils.logInfo(`Current auction contains ${adUnitsLen} adUnits.`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add auction id in the message as well ? It will help them track down everything related to auction.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the log message to include some additional info. Please take a look.

}

adUnits.forEach((adUnit) => {
const mediaTypes = adUnit.mediaTypes;
const normalizedSize = utils.getAdUnitSizes(adUnit);
Expand Down