add console message when number of adunits exceeds point #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/prebid.js
Outdated
| @@ -70,6 +70,11 @@ function setRenderSize(doc, width, height) { | |||
| } | |||
|
|
|||
| export const checkAdUnitSetup = hook('sync', function (adUnits) { | |||
| let adUnitsLen = adUnits.length; | |||
| if (adUnitsLen > 15) { | |||
| utils.logInfo(`Current auction contains ${adUnitsLen} adUnits.`); | |||
There was a problem hiding this comment.
Should we add auction id in the message as well ? It will help them track down everything related to auction.
There was a problem hiding this comment.
I updated the log message to include some additional info. Please take a look.
harpere
approved these changes
Apr 5, 2019
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* add console message when number of adunits exceeds point * include additional information in log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds a console message when the number of
adUnits for an auction exceeds a certain amount (currently set to 15). This is to help notify publishers of their setup and to potentially review it if the number seems incorrect or too high.