Skip to content

feat: adding find minikube util method #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Oct 18, 2024

Following #165 simplification.

Notable change

  • Adding findMinikube util method. _What is the difference between findMinikube and detectMinikube ?
findMinikube detectMinikube
findMinikube detect binary installed by MinikubeDownload detectMinikube detect binary installed by MinikubeInstaller

⚠️ I cannot replace yet detectMinikube by findMinikube because the status bar still uses MinikubeInstaller to install the binary

  • MinikubeInstaller and detectMinikube are marked as deprecated

ℹ️ Why marking them as deprecated ? Because we have duplicate logic, that will need to be removed, and I want to make small PR, so I will not delete and replace everything at once, so the follow-up PR will be replacing detectMinikube, and then another deleting unused code.

@axel7083 axel7083 requested a review from benoitf as a code owner October 18, 2024 09:18
@axel7083 axel7083 merged commit 5ba894d into podman-desktop:main Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants