feat: adding find minikube util method (#171)

* feat: adding find minikube util method

Signed-off-by: axel7083 <[email protected]>

* fix: moving findMinikube to MinikubeDownload class

Signed-off-by: axel7083 <[email protected]>

---------

Signed-off-by: axel7083 <[email protected]>

Author: axel7083

src/download.spec.ts

@@ -22,15 +22,15 @@ import { beforeEach } from 'node:test';
 
 import type { Octokit } from '@octokit/rest';
 import type * as extensionApi from '@podman-desktop/api';
-import { env } from '@podman-desktop/api';
+import { env, process as processCore } from '@podman-desktop/api';
 import { afterEach, describe, expect, test, vi } from 'vitest';
 
 import type { MinikubeGithubReleaseArtifactMetadata } from './download';
 import { MinikubeDownload } from './download';
 
 // Create the OS class as well as fake extensionContext
 const extensionContext: extensionApi.ExtensionContext = {
-  storagePath: '/fake/path',
+  storagePath: '/extension-folder/',
   subscriptions: [],
 } as unknown as extensionApi.ExtensionContext;
 
@@ -56,6 +56,9 @@ vi.mock('@podman-desktop/api', () => ({
     isLinux: false,
     isMac: false,
   },
+  process: {
+    exec: vi.fn(),
+  },
 }));
 
 const listReleaseAssetsMock = vi.fn();
@@ -157,3 +160,44 @@ describe('getMinikubeExtensionPath', () => {
     expect(minikubeDownload.getMinikubeExtensionPath()).toStrictEqual(expect.stringMatching('.*\\minikube$'));
   });
 });
+
+describe('findMinikube', () => {
+  test('should use system wide first', async () => {
+    (env.isWindows as boolean) = true;
+
+    const minikubeDownload = new MinikubeDownload(extensionContext, octokitMock);
+
+    vi.mocked(processCore.exec).mockResolvedValue({
+      stdout: '/dummy/tmp/minikube',
+      stderr: '',
+      command: '',
+    });
+
+    const result = await minikubeDownload.findMinikube();
+    expect(result).toBe('/dummy/tmp/minikube');
+  });
+
+  test('system wide missing should fallback to local extension folder', async () => {
+    (env.isWindows as boolean) = false;
+    vi.mocked(processCore.exec).mockRejectedValue(new Error('dummy error'));
+
+    const minikubeDownload = new MinikubeDownload(extensionContext, octokitMock);
+
+    vi.mocked(fs.existsSync).mockReturnValue(true);
+
+    const result = await minikubeDownload.findMinikube();
+    expect(result).toStrictEqual(expect.stringContaining('extension-folder'));
+  });
+
+  test('system wide missing should fallback to local extension folder', async () => {
+    (env.isWindows as boolean) = false;
+    vi.mocked(processCore.exec).mockRejectedValue(new Error('dummy error'));
+
+    const minikubeDownload = new MinikubeDownload(extensionContext, octokitMock);
+
+    vi.mocked(fs.existsSync).mockReturnValue(false);
+
+    const result = await minikubeDownload.findMinikube();
+    expect(result).toBeUndefined();
+  });
+});

src/download.ts

@@ -25,6 +25,8 @@ import type { Octokit } from '@octokit/rest';
 import type * as extensionApi from '@podman-desktop/api';
 import { env } from '@podman-desktop/api';
 
+import { whereBinary } from './util';
+
 export interface MinikubeGithubReleaseArtifactMetadata {
   tag: string;
   id: number;
@@ -74,6 +76,22 @@ export class MinikubeDownload {
     return path.resolve(this.extensionContext.storagePath, `minikube${fileExtension}`);
   }
 
+  /**
+   * search if minikube is available in the path or in the extension folder
+   */
+  async findMinikube(): Promise<string | undefined> {
+    try {
+      return await whereBinary('minikube');
+    } catch (err: unknown) {
+      console.debug(err);
+    }
+
+    const extensionPath = this.getMinikubeExtensionPath();
+    if (fs.existsSync(extensionPath)) {
+      return extensionPath;
+    }
+  }
+
   // Download minikube from the artifact metadata: MinikubeGithubReleaseArtifactMetadata
   // this will download it to the storage bin folder as well as make it executable
   // return the path where the file has been downloaded

src/minikube-installer.ts

@@ -56,6 +56,9 @@ const MACOS_X64_ASSET_NAME = 'minikube-darwin-amd64';
 
 const MACOS_ARM64_ASSET_NAME = 'minikube-darwin-arm64';
 
+/**
+ * @deprecated use {@link MinikubeDownload} instead
+ */
 export class MinikubeInstaller {
   private assetNames = new Map<string, string>();
 

src/util.ts

@@ -51,7 +51,12 @@ export function getMinikubeHome(): string | undefined {
   }
 }
 
-// search if minikube is available in the path
+/**
+ * search if minikube is available in the path
+ * @param pathAddition
+ * @param installer
+ * @deprecated use {@link MinikubeDownload#findMinikube}
+ */
 export async function detectMinikube(pathAddition: string, installer: MinikubeInstaller): Promise<string> {
   try {
     await extensionApi.process.exec('minikube', ['version'], {