refactor(MinikubeDownload): expose extension executable path (#170)

* refactor(MinikubeDownload): expose extension executable path

Signed-off-by: axel7083 <[email protected]>

* fix: prettier

Signed-off-by: axel7083 <[email protected]>

---------

Signed-off-by: axel7083 <[email protected]>

Author: axel7083

src/download.spec.ts

@@ -22,7 +22,8 @@ import { beforeEach } from 'node:test';
 
 import type { Octokit } from '@octokit/rest';
 import type * as extensionApi from '@podman-desktop/api';
-import { afterEach, expect, test, vi } from 'vitest';
+import { env } from '@podman-desktop/api';
+import { afterEach, describe, expect, test, vi } from 'vitest';
 
 import type { MinikubeGithubReleaseArtifactMetadata } from './download';
 import { MinikubeDownload } from './download';
@@ -49,6 +50,14 @@ const releases: MinikubeGithubReleaseArtifactMetadata[] = [
   };
 });
 
+vi.mock('@podman-desktop/api', () => ({
+  env: {
+    isWindows: false,
+    isLinux: false,
+    isMac: false,
+  },
+}));
+
 const listReleaseAssetsMock = vi.fn();
 const listReleasesMock = vi.fn();
 const getReleaseAssetMock = vi.fn();
@@ -132,3 +141,19 @@ test('test download of minikube passes and that mkdir and executable mocks are c
   expect(mkdirMock).toHaveBeenCalled();
   expect(makeExecutableMock).toHaveBeenCalled();
 });
+
+describe('getMinikubeExtensionPath', () => {
+  test('window platform should add .exe suffix', async () => {
+    (env.isWindows as boolean) = true;
+
+    const minikubeDownload = new MinikubeDownload(extensionContext, octokitMock);
+    expect(minikubeDownload.getMinikubeExtensionPath()).toStrictEqual(expect.stringMatching('.*\\minikube.exe$'));
+  });
+
+  test('non-window platform should not add .exe suffix', async () => {
+    (env.isWindows as boolean) = false;
+
+    const minikubeDownload = new MinikubeDownload(extensionContext, octokitMock);
+    expect(minikubeDownload.getMinikubeExtensionPath()).toStrictEqual(expect.stringMatching('.*\\minikube$'));
+  });
+});

src/download.ts

@@ -23,6 +23,7 @@ import * as path from 'node:path';
 
 import type { Octokit } from '@octokit/rest';
 import type * as extensionApi from '@podman-desktop/api';
+import { env } from '@podman-desktop/api';
 
 export interface MinikubeGithubReleaseArtifactMetadata {
   tag: string;
@@ -65,6 +66,14 @@ export class MinikubeDownload {
     return latestReleases[0];
   }
 
+  getMinikubeExtensionPath(): string {
+    let fileExtension = '';
+    if (env.isWindows) {
+      fileExtension = '.exe';
+    }
+    return path.resolve(this.extensionContext.storagePath, `minikube${fileExtension}`);
+  }
+
   // Download minikube from the artifact metadata: MinikubeGithubReleaseArtifactMetadata
   // this will download it to the storage bin folder as well as make it executable
   // return the path where the file has been downloaded
@@ -74,17 +83,12 @@ export class MinikubeDownload {
 
     // Get the storage and check to see if it exists before we download kubectl
     const storageData = this.extensionContext.storagePath;
-    const storageBinFolder = path.resolve(storageData, 'bin');
-    if (!existsSync(storageBinFolder)) {
-      await promises.mkdir(storageBinFolder, { recursive: true });
+    if (!existsSync(storageData)) {
+      await promises.mkdir(storageData, { recursive: true });
     }
 
     // Correct the file extension and path resolution
-    let fileExtension = '';
-    if (process.platform === 'win32') {
-      fileExtension = '.exe';
-    }
-    const minikubeDownloadLocation = path.resolve(storageBinFolder, `minikube${fileExtension}`);
+    const minikubeDownloadLocation = this.getMinikubeExtensionPath();
 
     // Download the asset and make it executable
     await this.downloadReleaseAsset(assetId, minikubeDownloadLocation);