refactor(MinikubeDownload): expose extension executable path #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <[email protected]>
benoitf
approved these changes
Oct 18, 2024
|
(just need to fix the formatting) |
Signed-off-by: axel7083 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @benoitf comment #165 (comment) trying to make very small changes.
This PR expose the path where the executable will be located inside the extension folder. This will be useful in other component to be able to use it to execute
<minikube-path> --version.Notable change
The
MinikubeDownloadwas saving the executable in<extension-folder>/bin/minikube(.exe)but theMinikubeInstalleris saving to<extension-folder>/minikube-<platform>-<arch>(.exe). To simplify that, this PR remove thebinfolder, as it is not used by any extensions (kind, compose, etc.)Tests