Implemented sound when equipping armor #6303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShockedPlot7560
added
Category: Gameplay
dktapps
approved these changes
Mar 25, 2024
ShockedPlot7560
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR takes up #5416 due to his author inactivity. I have rewritten the PR to use the ArmorMaterial and fixed the behaviour: At present, in vanilla, armor sounds are also played when equipping the armor via inventory, dispenser, commands.
Relevant issues
Closes #5167
Changes
API changes
Added
getEquipSound() : ?Soundto ArmorMaterialAdded the new following sound classes:
ArmorEquipChainSound,ArmorEquipDiamondSound,ArmorEquipGenericSound,ArmorEquipGoldSound,ArmorEquipIronSound,ArmorEquipLeatherSound,ArmorEquipNetheriteSound.I tested this PR by doing the following: