Add missing sounds when equipping or unequipping armour using right-c… #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the sound of Netherite armor is missing |
Yeah, but Netherite is not implemented in stable |
|
I didn't look at the branch 💀 |
|
You sure? I think I should change the targeting branch to next-minor because I only added new API classes |
|
next-minor is fine |
jasonw4331
added
Category: Gameplay
dktapps
added
Type: Enhancement
dktapps
requested changes
Dec 6, 2022
…nequipping-armour-using-right-click
jasonw4331
approved these changes
Mar 17, 2023
dktapps
reviewed
Mar 27, 2023
dktapps
approved these changes
Aug 7, 2023
|
Is merge planned? |
|
Yes, but I'll need to re-review it once the branches are in sync |
|
I think it would be better if we add the equip sounds to |
|
Yeah, I agree |
1 task
|
Superseeded by f799cfa |
ShockedPlot7560
added
Resolution: Abandoned
zSALLAZAR
deleted the
add-missing-sounds-when-equipping-or-unequipping-armour-using-right-click
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lick
Introduction
Relevant issues
#5167
Changes
API changes
Behavioural changes
Backwards compatibility
Follow-up
Tests
Minecraft.2022-11-16.11-23-15.mp4