Skip to content

Search results with breadcrumbs. Search with filters by section. #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 16, 2025

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Mar 15, 2025

Fixes #1913

before

Item-0_and_Item-0_and_Item-0_and_Item-0_and_Item-0

with this PR change

Search_-_Plone_Documentation_v6


📚 Documentation preview 📚: https://plone6--1914.org.readthedocs.build/

[EDIT] search with filter by category is postponed to later.

@ksuess
Copy link
Member Author

ksuess commented Mar 15, 2025

This PR enhances search results with breadcrumbs telling where the match is located. And it enhances the search with a filter by section.
This PR does not care about layout and it does not care about proper url param like 'training' instead of 'section'. If you do, open an issue and pull request to enhance further.

@ksuess ksuess marked this pull request as ready for review March 15, 2025 17:05
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why all the search results say "...Repository" for each item instead of the search term in context. Can you investigate?

Comment on lines 95 to 96
"Plone trainings",
"Training for Plone developers"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these reflect Plone 6 Documentation?

@github-project-automation github-project-automation bot moved this from New to In Progress in Plone Documentation Mar 16, 2025
@ksuess
Copy link
Member Author

ksuess commented Mar 16, 2025

search is updated. description should be OK now, even for the rare cases I found.
If you have more bad examples, please write here.

@stevepiercy stevepiercy merged commit fa8c090 into 6.0 Mar 16, 2025
3 checks passed
@stevepiercy stevepiercy deleted the search branch March 16, 2025 21:46
@github-project-automation github-project-automation bot moved this from In Progress to Done in Plone Documentation Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Search results with breadcrumbs. Search with filters by section.
2 participants