-
-
Notifications
You must be signed in to change notification settings - Fork 176
Search results with breadcrumbs. Search with filters by section. #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I raise the issue, I propose an implementation. |
@ksuess how can we implement search by category together with Nuclia search? Now that I have Plone Sphinx Theme stabilized, that's the next big step forward. |
Additionally, without hard-coding the categories now, I would prefer to do this upstream in Plone Sphinx Theme. I want to minimize the number of files that we have to modify across the increasing number of Plone documentation sites. We can package template, JavaScript, and CSS files in the distribution now. |
I am aware that this change here will be replaced with a future AI search. And I am fine with it. And, yes, a lift to the theme Plone-sphinx-theme would be great, if it's possible to do it in a way, that the documentation that uses the theme can configure the categories. If that's not possible. I am fine with not implementing the category filter. |
Here are my concerns.
|
@ksuess until we can implement Nuclia, I'm OK with adding this in the short-term. However, if it breaks from an update to Sphinx or upstream themes, then we'll have to remove it and fallback to the default Sphinx search. Would that be reasonable? |
I am happy with an intermediate solution that adds breadcrumbs or just the category/section to search results. |
If opinions tend to not showing a filter for categories, I am fine with removing this from this PR. My prio is the category on the search result. |
Maybe we can do the change here and kick it out when the AI search is installed. |
Agreed. I just submitted a review of the PR. There's a possible bug, a tweak, and a question for you. Thank you! |
before:
The text was updated successfully, but these errors were encountered: