Skip to content

Bootstrap Icons 1.11.3 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

PanderMusubi
Copy link
Contributor

No description provided.

@The-Lum
Copy link
Collaborator

The-Lum commented Apr 30, 2025

@PanderMusubi, @arnaudroques

I'm a little lost...
Sorry for the abrupt remarks

Warning

Beware: here is a point of attention:

  • There are a lot of MA_ACCOUNT_MINUS on all the files...

It seems these functions are not linked to the sprite name...

Perhaps:

  • either factor into a common file
  • either change all the name according to the good sprite name and add sprite param.

Other remarks:

Sorry for the abrupt remarks
Regards,
Th.

@PanderMusubi
Copy link
Contributor Author

This was a first attempt. Please, unmerge it until reviews are done. Thanks.

@PanderMusubi
Copy link
Contributor Author

Or leave it.merged but do not make a new release until all the issues have been addressed.

@PanderMusubi PanderMusubi mentioned this pull request Apr 30, 2025
@arnaudroques
Copy link
Contributor

Or leave it.merged but do not make a new release until all the issues have been addressed.

Yes, don't worry.
We won't make a new release until then.

It's really not an issue: the file are manually copied to the main plantuml repo, so we can work this way.

Many thanks for your contribution!

arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>
arnaudroques pushed a commit that referenced this pull request May 4, 2025
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrapsvg (#135)

* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>

* add a link from `bootstrap` to `bootstrap1.11.3`

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>
arnaudroques added a commit that referenced this pull request May 4, 2025
* Bootstrapsvg (#135)

* Bootstrap Icons 1.11.3 (#131)

* Auto-generated (update output with latest stdlib)

* Bootstrap Icons SVG

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>

* add a link from `bootstrap` to `bootstrap1.11.3`

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: arnaudroques <[email protected]>
Co-authored-by: Pander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants