Skip to content

Improve contributing docs #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

Improve contributing docs #5847

merged 5 commits into from
May 19, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented May 19, 2025

What this PR does:

  • Update copyright year on some docs.
  • Add a note about the issue assignment to the contributing documents.

Why we need it:

  • To avoid redundant works

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov Codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.80%. Comparing base (9dc4a8d) to head (22af4a3).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5847   +/-   ##
=======================================
  Coverage   27.80%   27.80%           
=======================================
  Files         510      510           
  Lines       54301    54301           
=======================================
+ Hits        15098    15101    +3     
+ Misses      38057    38054    -3     
  Partials     1146     1146

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc added the contribex Improve contributor experience label May 19, 2025
@Warashi
Clarify the process of working on issues
ea8fef1 
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@t-kikuc t-kikuc marked this pull request as ready for review May 19, 2025 04:39
t-kikuc
t-kikuc previously approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important!

khanhtc1202
khanhtc1202 reviewed May 19, 2025
View reviewed changes
@Warashi @khanhtc1202
Update CONTRIBUTING.md
22af4a3 
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
khanhtc1202
khanhtc1202 approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Warashi Warashi enabled auto-merge (squash) May 19, 2025 04:49
@Warashi Warashi merged commit 750e0ce into master May 19, 2025
20 checks passed
@Warashi Warashi deleted the improve-contributing-docs branch May 19, 2025 04:52
@t-kikuc t-kikuc mentioned this pull request May 19, 2025
Open
Tushar240503 pushed a commit to Tushar240503/pipecd that referenced this pull request May 20, 2025
@Warashi @khanhtc1202 @Tushar240503
Improve contributing docs (pipe-cd#5847)
15645eb 
* Update copyright year in CONTRIBUTING.md to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update copyright year in boilerplate.go.txt to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add note about issue assignment to contributing docs

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Clarify the process of working on issues

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Tushar240503 <[email protected]>
Tushar240503 pushed a commit to Tushar240503/pipecd that referenced this pull request May 20, 2025
@Warashi @khanhtc1202 @Tushar240503
Improve contributing docs (pipe-cd#5847)
e93804a 
* Update copyright year in CONTRIBUTING.md to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update copyright year in boilerplate.go.txt to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add note about issue assignment to contributing docs

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Clarify the process of working on issues

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Tushar240503 <[email protected]>
Tushar240503 pushed a commit to Tushar240503/pipecd that referenced this pull request May 20, 2025
@Warashi @khanhtc1202 @Tushar240503
Improve contributing docs (pipe-cd#5847)
f8593f8 
* Update copyright year in CONTRIBUTING.md to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update copyright year in boilerplate.go.txt to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add note about issue assignment to contributing docs

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Clarify the process of working on issues

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Tushar240503 <[email protected]>
Tushar240503 pushed a commit to Tushar240503/pipecd that referenced this pull request May 20, 2025
@Warashi @khanhtc1202 @Tushar240503
Improve contributing docs (pipe-cd#5847)
25410f7 
* Update copyright year in CONTRIBUTING.md to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update copyright year in boilerplate.go.txt to 2025

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Add note about issue assignment to contributing docs

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Clarify the process of working on issues

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
@github-actions github-actions bot mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@t-kikuc t-kikuc t-kikuc approved these changes

@ffjlabo ffjlabo Awaiting requested review from ffjlabo

Assignees
No one assigned
Labels
area/build contribex Improve contributor experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Warashi @khanhtc1202 @t-kikuc