Skip to content

Commit 15645eb

Browse files
Warashikhanhtc1202
authored andcommitted
Improve contributing docs (pipe-cd#5847)
* Update copyright year in CONTRIBUTING.md to 2025 Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Update copyright year in boilerplate.go.txt to 2025 Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Add note about issue assignment to contributing docs Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Clarify the process of working on issues Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: Tushar240503 <[email protected]>
1 parent 458f540 commit 15645eb

File tree

2 files changed

+80
-65
lines changed

2 files changed

+80
-65
lines changed

CONTRIBUTING.md

Lines changed: 79 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ All pull requests undergo checks by the continuous integration system, GitHub Ac
3939

4040
PipeCD has one primary branch `master`.
4141

42-
## Issues
42+
## Open a new issue
4343

4444
When [opening a new issue](https://github.com/pipe-cd/pipecd/issues/new/choose), please make sure to fill out the issue template. This step is crucial! Neglecting to do so may result in your issue not being promptly addressed. If this happens, feel free to open a new issue once you have gathered all the necessary information.
4545

@@ -65,12 +65,89 @@ If you would like to request an enhancement to existing features, you can file a
6565

6666
If you would like to request an entirely new feature, you can file an issue with the [feature request](https://github.com/pipe-cd/pipecd/issues/new?assignees=&labels=kind%2Ffeature&projects=&template=new-feature.md).
6767

68-
### Claiming issues
68+
## Working on issues
69+
70+
### Good first issues
6971

7072
We maintain a list of [good first issues](https://github.com/pipe-cd/pipecd/labels/good%20first%20issue) to help you get started with the PipeCD codebase and familiarize yourself with our contribution process. It's an excellent place to begin.
7173

74+
Additionally, we recommend you not to work on multiple good first issues because it's for first contributers and currently we cannot make enough good first issues.
75+
76+
### Before you work on issues
77+
7278
If you want to work on any of these issues, simply leave a message saying "I'd like to work on this," and we will assign the issue to you and update its status as "claimed." We expect you to submit a pull request within seven days so that we can assign the issue to someone else if you are unavailable.
7379

80+
We recommend you to focus only one issue at once if you are newcomer contributer.
81+
82+
So you've decided to contribute back to the upstream by opening a pull request. You've put in a significant amount of time, and we appreciate your effort. We will do our best to work with you and review the pull request.
83+
84+
### Investigate an issue
85+
86+
Before you submitting a Pull Request, we recommend you to investigate the issue and comment what to do on it.
87+
Then you can discuss how to solve the issue and reduce the communication on the Pull Request.
88+
89+
### Submitting a Pull Request
90+
91+
Are you working on your first Pull Request? You can learn how to do it from this free video series:
92+
93+
[**How to Contribute to an Open Source Project on GitHub**](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github)
94+
95+
When submitting a pull request, please ensure the following:
96+
97+
- **Issue assignment.** To avoid redundant work, make sure you are assigned to the issue.
98+
- **Keep your PR small.** Small pull requests (~300 lines of diff) are much easier to review and are more likely to get merged. Make sure the PR addresses only one thing. If not, please split it.
99+
- **Use descriptive titles.** It is recommended to follow the [commit message style](#commit-messages).
100+
- **DCO.** If you haven't signed off already, check the [Contributor License Agreement](#contributor-license-agreement).
101+
102+
All pull requests should be opened against the `master` branch.
103+
104+
We have various integration systems that run automated tests to prevent mistakes. The maintainers will also review your code and fix obvious issues. These systems are in place to minimize your worries about the process. Your code contributions are more important than adhering to strict procedures, although completing the checklist will undoubtedly save everyone's time.
105+
106+
### Commit Messages
107+
108+
Commit messages should be simple and use easy words that indicate the focus of the commit and its impact on other developers. Summary in the present tense. Use capital case in the first character but do not use title case.
109+
110+
Example
111+
112+
```
113+
Add imports to Terraform plan result
114+
```
115+
116+
Don't stress too much about PR titles. The maintainers will help you get the title right.
117+
118+
### Licensing
119+
120+
By contributing to PipeCD, you agree that your contributions will be licensed under the Apache License Version 2. Include the following header at the top of your new file(s):
121+
122+
```go
123+
// Copyright 2025 The PipeCD Authors.
124+
//
125+
// Licensed under the Apache License, Version 2.0 (the "License");
126+
// you may not use this file except in compliance with the License.
127+
// You may obtain a copy of the License at
128+
//
129+
// http://www.apache.org/licenses/LICENSE-2.0
130+
//
131+
// Unless required by applicable law or agreed to in writing, software
132+
// distributed under the License is distributed on an "AS IS" BASIS,
133+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
134+
// See the License for the specific language governing permissions and
135+
// limitations under the License.
136+
```
137+
138+
### Release Note and Breaking Changes
139+
140+
If your change introcudes a user-facing change, please update the following section in your PR description.
141+
142+
```md
143+
**Does this PR introduce a user-facing change?**:
144+
- **How are users affected by this change**:
145+
- **Is this breaking change**:
146+
- **How to migrate (if breaking change)**:
147+
```
148+
149+
Note that if it's a new breaking change, make sure to complete the two latter questions.
150+
74151
## Development
75152

76153
PipeCD consists of several components and docs:
@@ -164,68 +241,6 @@ Then, copy generated Piped ID and base64 key for `piped-config.yaml`
164241

165242
We are preparing Gitpod and Codespace to facilitate the setup process for contributing.
166243

167-
## Pull Requests
168-
169-
So you've decided to contribute code back to the upstream by opening a pull request. You've put in a significant amount of time, and we appreciate your effort. We will do our best to work with you and review the pull request.
170-
171-
Are you working on your first Pull Request? You can learn how to do it from this free video series:
172-
173-
[**How to Contribute to an Open Source Project on GitHub**](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github)
174-
175-
When submitting a pull request, please ensure the following:
176-
177-
- **Keep your PR small.** Small pull requests (~300 lines of diff) are much easier to review and are more likely to get merged. Make sure the PR addresses only one thing. If not, please split it.
178-
- **Use descriptive titles.** It is recommended to follow the [commit message style](#commit-messages).
179-
- **DCO.** If you haven't signed off already, check the [Contributor License Agreement](#contributor-license-agreement).
180-
181-
All pull requests should be opened against the `master` branch.
182-
183-
We have various integration systems that run automated tests to prevent mistakes. The maintainers will also review your code and fix obvious issues. These systems are in place to minimize your worries about the process. Your code contributions are more important than adhering to strict procedures, although completing the checklist will undoubtedly save everyone's time.
184-
185-
### Commit Messages
186-
Commit messages should be simple and use easy words that indicate the focus of the commit and its impact on other developers. Summary in the present tense. Use capital case in the first character but do not use title case.
187-
188-
Example
189-
190-
```
191-
Add imports to Terraform plan result
192-
```
193-
194-
Don't stress too much about PR titles. The maintainers will help you get the title right.
195-
196-
### Licensing
197-
198-
By contributing to PipeCD, you agree that your contributions will be licensed under the Apache License Version 2. Include the following header at the top of your new file(s):
199-
200-
```go
201-
// Copyright 2024 The PipeCD Authors.
202-
//
203-
// Licensed under the Apache License, Version 2.0 (the "License");
204-
// you may not use this file except in compliance with the License.
205-
// You may obtain a copy of the License at
206-
//
207-
// http://www.apache.org/licenses/LICENSE-2.0
208-
//
209-
// Unless required by applicable law or agreed to in writing, software
210-
// distributed under the License is distributed on an "AS IS" BASIS,
211-
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
212-
// See the License for the specific language governing permissions and
213-
// limitations under the License.
214-
```
215-
216-
### Release Note and Breaking Changes
217-
218-
If your change introcudes a user-facing change, please update the following section in your PR description.
219-
220-
```md
221-
**Does this PR introduce a user-facing change?**:
222-
- **How are users affected by this change**:
223-
- **Is this breaking change**:
224-
- **How to migrate (if breaking change)**:
225-
```
226-
227-
Note that if it's a new breaking change, make sure to complete the two latter questions.
228-
229244
## Contributor License Agreement
230245

231246
For any code contribution, please carefully read the following documents:

hack/boilerplate.go.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2024 The PipeCD Authors.
1+
// Copyright 2025 The PipeCD Authors.
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)