Skip to content

Add comment for the plugins field in generic application config #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Add comment for the plugins field in generic application config #5801

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52c379d
Add comment for the plugins field in generic application config
ffjlabo May 7, 2025
2dba71d
Fix comment
ffjlabo May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/configv1/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ type GenericApplicationSpec struct {
// Configuration for drift detection
DriftDetection *DriftDetection `json:"driftDetection"`
// List of the plugin name
// This field is plugin-specific, so intentionally restrict the access for the actual value here and decode it on the SDK side.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should rewrite the above line either. Since it's not just list of plugin name anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed 2dba71d

Plugins map[string]struct{} `json:"plugins"`
}

Expand Down