Add comment for the plugins field in generic application config #5801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5801 +/- ##
==========================================
- Coverage 27.14% 27.14% -0.01%
==========================================
Files 506 508 +2
Lines 53705 53803 +98
==========================================
+ Hits 14577 14603 +26
- Misses 38013 38084 +71
- Partials 1115 1116 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khanhtc1202
reviewed
May 7, 2025
| @@ -59,6 +59,7 @@ type GenericApplicationSpec struct { | |||
| // Configuration for drift detection | |||
| DriftDetection *DriftDetection `json:"driftDetection"` | |||
| // List of the plugin name | |||
| // This field is plugin-specific, so intentionally restrict the access for the actual value here and decode it on the SDK side. | |||
There was a problem hiding this comment.
So we should rewrite the above line either. Since it's not just list of plugin name anymore
Signed-off-by: Yoshiki Fujikane <[email protected]>
t-kikuc
approved these changes
May 12, 2025
ffjlabo
deleted the
add-comment-for-plugins-field-in-generic-application-config
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as titlw
Why we need it:
We want to clarify why defined
spec.pluginsare empty struct.Which issue(s) this PR fixes:
Follow #5789
Does this PR introduce a user-facing change?: no