Skip to content

Add depguard rule to restrict pipedv1 to use configv1 #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented Apr 10, 2025

What this PR does:

as title

Why we need it:

We must use configv1 package under the pipedv1 package

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Warashi added 2 commits April 11, 2025 08:25
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Comment on lines -60 to -62
for _, cp := range cfg.PlatformProviders {
_ = cp // TODO: general state from plugin from store fields
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlatformProvider doesn't exists in configv1 package

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.96%. Comparing base (d9f71b2) to head (e3b8aa6).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/livestatestore/livestatestore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5732   +/-   ##
=======================================
  Coverage   26.95%   26.96%           
=======================================
  Files         502      503    +1     
  Lines       53018    53023    +5     
=======================================
+ Hits        14291    14297    +6     
+ Misses      37663    37662    -1     
  Partials     1064     1064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review April 10, 2025 23:42
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful rule!!

@t-kikuc t-kikuc enabled auto-merge (squash) April 14, 2025 07:54
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update 👍

@t-kikuc t-kikuc merged commit 944139c into master Apr 14, 2025
17 of 18 checks passed
@t-kikuc t-kikuc deleted the golangci-lint-depguard branch April 14, 2025 15:44
@github-actions github-actions bot mentioned this pull request May 15, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants