-
Notifications
You must be signed in to change notification settings - Fork 182
Add depguard rule to restrict pipedv1 to use configv1 #5732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
for _, cp := range cfg.PlatformProviders { | ||
_ = cp // TODO: general state from plugin from store fields | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlatformProvider
doesn't exists in configv1 package
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5732 +/- ##
=======================================
Coverage 26.95% 26.96%
=======================================
Files 502 503 +1
Lines 53018 53023 +5
=======================================
+ Hits 14291 14297 +6
+ Misses 37663 37662 -1
Partials 1064 1064 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful rule!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update 👍
What this PR does:
as title
Why we need it:
We must use configv1 package under the pipedv1 package
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No