Add depguard rule to restrict pipedv1 to use configv1 (#5732)

* Add depguard rule for pipedv1

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Fix depguard lint error

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

* Restore TODO comments

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>

Author: Warashi

.golangci.yml

@@ -46,6 +46,12 @@ linters-settings:
             desc: "Use go.uber.org/atomic instead of sync/atomic."
           - pkg: "io/ioutil"
             desc: "Use corresponding 'os' or 'io' functions instead."
+      pipedv1:
+        files:
+          - "**/pkg/app/pipedv1/**/*.go"
+        deny:
+          - pkg: "github.com/pipe-cd/pipecd/pkg/config$"
+            desc: "Use github.com/pipe-cd/pipecd/pkg/configv1 instead."
   gocritic:
     disabled-checks:
       - appendAssign

pkg/app/pipedv1/livestatestore/livestatestore.go

@@ -25,7 +25,7 @@ import (
 	"go.uber.org/zap"
 	"golang.org/x/sync/errgroup"
 
-	"github.com/pipe-cd/pipecd/pkg/config"
+	config "github.com/pipe-cd/pipecd/pkg/configv1"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )
 
@@ -57,9 +57,7 @@ func NewStore(ctx context.Context, cfg *config.PipedSpec, appLister applicationL
 		gracePeriod: gracePeriod,
 		logger:      logger,
 	}
-	for _, cp := range cfg.PlatformProviders {
-		_ = cp // TODO: general state from plugin from store fields
-	}
+	// TODO: general state from plugin from store fields
 
 	return s
 }

pkg/app/pipedv1/notifier/matcher.go

@@ -15,7 +15,7 @@
 package notifier
 
 import (
-	"github.com/pipe-cd/pipecd/pkg/config"
+	config "github.com/pipe-cd/pipecd/pkg/configv1"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )
 

pkg/app/pipedv1/notifier/matcher_test.go

@@ -19,7 +19,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 
-	"github.com/pipe-cd/pipecd/pkg/config"
+	config "github.com/pipe-cd/pipecd/pkg/configv1"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )
 

pkg/app/pipedv1/notifier/slack.go

@@ -29,7 +29,7 @@ import (
 	slackgo "github.com/slack-go/slack"
 	"go.uber.org/zap"
 
-	"github.com/pipe-cd/pipecd/pkg/config"
+	config "github.com/pipe-cd/pipecd/pkg/configv1"
 	"github.com/pipe-cd/pipecd/pkg/git"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )

pkg/app/pipedv1/notifier/webhook.go

@@ -24,7 +24,7 @@ import (
 
 	"go.uber.org/zap"
 
-	"github.com/pipe-cd/pipecd/pkg/config"
+	config "github.com/pipe-cd/pipecd/pkg/configv1"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )