-
Notifications
You must be signed in to change notification settings - Fork 183
Enable gofmt
linter
#5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gofmt
linter
#5630
Conversation
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
…gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5630 +/- ##
==========================================
+ Coverage 26.58% 26.65% +0.07%
==========================================
Files 477 477
Lines 50657 50740 +83
==========================================
+ Hits 13465 13526 +61
- Misses 36134 36147 +13
- Partials 1058 1067 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1,95 +0,0 @@ | |||
// Code generated by MockGen. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter warns for this file, but actually this file seems to be not needed.
I noticed the mock for the project store is already created in the pkg/datastore/datastoretest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
* Add gofmt linter Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix deployment_store_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/insight/provider_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/log/log_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/comment_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/release_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-plan-preview/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Use datastoretest.MockProjectStore Signed-off-by: Yoshiki Fujikane <[email protected]> --------- Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: kypham <[email protected]>
* Enable `gofmt` linter (#5630) * Add gofmt linter Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix deployment_store_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/insight/provider_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/log/log_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/comment_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/release_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-gh-release/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix tool/actions-plan-preview/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <[email protected]> * Use datastoretest.MockProjectStore Signed-off-by: Yoshiki Fujikane <[email protected]> --------- Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: kypham <[email protected]> * Set default value to depleoyment tracing UI - Add default title commit - hide trace.commitMessage when falsy - hide author when falsy Signed-off-by: kypham <[email protected]> * Update default title of commit deployment tracing Signed-off-by: kypham <[email protected]> --------- Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: kypham <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
What this PR does:
as title.
The target files are those below.
Every fix doesn't have any logic changes.
Why we need it:
We can detect some patterns.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: