Enable gofmt linter (#5630)

* Add gofmt linter

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix deployment_store_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/insight/provider_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/log/log_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix tool/actions-gh-release/comment_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix tool/actions-gh-release/release_test.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix tool/actions-gh-release/github.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix tool/actions-plan-preview/github.go for 'gofmt -s'

Signed-off-by: Yoshiki Fujikane <[email protected]>

* Use datastoretest.MockProjectStore

Signed-off-by: Yoshiki Fujikane <[email protected]>

---------

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: kypham <[email protected]>

Author: ffjlabo

.golangci.yml

@@ -4,6 +4,7 @@ run:
 linters:
   disable-all: true
   enable:
+    - gofmt
     - depguard
     - gocritic
     - goheader

pkg/app/ops/handler/handler_mock.go

@@ -25,16 +25,17 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/assert"
+	"go.uber.org/mock/gomock"
 	"go.uber.org/zap"
 
 	"github.com/pipe-cd/pipecd/pkg/config"
+	"github.com/pipe-cd/pipecd/pkg/datastore/datastoretest"
 	"github.com/pipe-cd/pipecd/pkg/model"
 )
 
-func createMockHandler(ctrl *gomock.Controller) (*MockprojectStore, *Handler) {
-	m := NewMockprojectStore(ctrl)
+func createMockHandler(ctrl *gomock.Controller) (*datastoretest.MockProjectStore, *Handler) {
+	m := datastoretest.NewMockProjectStore(ctrl)
 	logger, _ := zap.NewProduction()
 
 	h := NewHandler(

pkg/app/ops/handler/handler_test.go

@@ -228,7 +228,7 @@ func makeUmemo(twoU, n1 int, t []int) []map[ukey]float64 {
 	// bounds. It might be worth turning these into directly
 	// indexible slices.
 	A := make([]map[ukey]float64, K+1)
-	A[K] = map[ukey]float64{ukey{n1: n1, twoU: twoU}: 0}
+	A[K] = map[ukey]float64{{n1: n1, twoU: twoU}: 0}
 
 	// Compute memo table (k, n1, twoU) triples from high K values
 	// to low K values. This drives the recurrence relation

pkg/app/piped/executor/analysis/mannwhitney/udist.go

@@ -139,16 +139,16 @@ func apply(ctx context.Context, client provider.Client, sm provider.ServiceManif
 
 func waitRevisionReady(ctx context.Context, client provider.Client, revisionName string, retryDuration, retryTimeout time.Duration, lp executor.LogPersister) error {
 	shouldCheckConditions := map[string]struct{}{
-		"Active":              struct{}{},
-		"Ready":               struct{}{},
-		"ConfigurationsReady": struct{}{},
-		"RoutesReady":         struct{}{},
-		"ContainerHealthy":    struct{}{},
-		"ResourcesAvailable":  struct{}{},
+		"Active":              {},
+		"Ready":               {},
+		"ConfigurationsReady": {},
+		"RoutesReady":         {},
+		"ContainerHealthy":    {},
+		"ResourcesAvailable":  {},
 	}
 	mustPassConditions := map[string]struct{}{
-		"Ready":  struct{}{},
-		"Active": struct{}{},
+		"Ready":  {},
+		"Active": {},
 	}
 
 	doCheck := func() (bool, error) {

pkg/app/piped/executor/cloudrun/cloudrun.go

@@ -41,23 +41,23 @@ var (
 
 var (
 	TypeConditions = map[string]struct{}{
-		"Active":              struct{}{},
-		"Ready":               struct{}{},
-		"ConfigurationsReady": struct{}{},
-		"RoutesReady":         struct{}{},
-		"ContainerHealthy":    struct{}{},
-		"ResourcesAvailable":  struct{}{},
+		"Active":              {},
+		"Ready":               {},
+		"ConfigurationsReady": {},
+		"RoutesReady":         {},
+		"ContainerHealthy":    {},
+		"ResourcesAvailable":  {},
 	}
 	TypeHealthyServiceConditions = map[string]struct{}{
-		"Ready":               struct{}{},
-		"ConfigurationsReady": struct{}{},
-		"RoutesReady":         struct{}{},
+		"Ready":               {},
+		"ConfigurationsReady": {},
+		"RoutesReady":         {},
 	}
 	TypeHealthyRevisionConditions = map[string]struct{}{
-		"Ready":              struct{}{},
-		"Active":             struct{}{},
-		"ContainerHealthy":   struct{}{},
-		"ResourcesAvailable": struct{}{},
+		"Ready":              {},
+		"Active":             {},
+		"ContainerHealthy":   {},
+		"ResourcesAvailable": {},
 	}
 )
 

pkg/app/piped/platformprovider/cloudrun/cloudrun.go

@@ -142,7 +142,7 @@ func Test_reporter_flushSnapshots(t *testing.T) {
 		snapshotFlushInterval: 1 * time.Minute,
 		appLister: &fakeAPILister{
 			apps: []*model.Application{
-				&model.Application{
+				{
 					Id:   "app-id",
 					Name: "app-name",
 					GitPath: &model.ApplicationGitPath{