Skip to content

Cherry-pick #5424 #5425 #5443 #5461 #5464 #5498 #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

What this PR does / why we need it:
Cherry pick of #5424 #5425 #5443 #5461 #5464 #5498.

t-kikuc and others added 6 commits January 21, 2025 04:53
* Add missing fields in RegisterTaskDef

Signed-off-by: t-kikuc <[email protected]>

* remove two restrictions

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
…edTags` (#5425)

* Enable updating PropagateTags and specifying other than SERVICE

Signed-off-by: t-kikuc <[email protected]>

* Enable updating EnableECSManagedTags

Signed-off-by: t-kikuc <[email protected]>

* Remove default PropagateTags: unnecessary

Signed-off-by: t-kikuc <[email protected]>

* support propagateTags other than SERVICE

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* Add logger.Error() before returning for detailed logs

Signed-off-by: t-kikuc <[email protected]>

* Enhance error logging in event watcher with additional context for push and commit failures

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
…LBACK (#5464)

* Add TriggeredCommandar

Signed-off-by: t-kikuc <[email protected]>

* add isRollback

Signed-off-by: t-kikuc <[email protected]>

* update docs

Signed-off-by: t-kikuc <[email protected]>

* fix name->id

Signed-off-by: t-kikuc <[email protected]>

* fix env name

Signed-off-by: t-kikuc <[email protected]>

* fix: specify isRollback since deployment.Status is always Planned

Signed-off-by: t-kikuc <[email protected]>

* fix typo

Signed-off-by: t-kikuc <[email protected]>

* Add case of `pipectl sync`

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
@Warashi Warashi closed this Jan 21, 2025
@Warashi Warashi reopened this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 3.03030% with 64 lines in your changes missing coverage. Please review.

Project coverage is 25.73%. Comparing base (cd3c295) to head (1dbd83c).
Report is 1 commits behind head on release-v0.50.x.

Files with missing lines Patch % Lines
pkg/app/piped/eventwatcher/eventwatcher.go 0.00% 48 Missing ⚠️
pkg/app/piped/platformprovider/ecs/client.go 0.00% 10 Missing ⚠️
pkg/app/piped/executor/scriptrun/scriptrun.go 33.33% 4 Missing ⚠️
pkg/app/piped/executor/kubernetes/rollback.go 0.00% 1 Missing ⚠️
pkg/app/piped/executor/wait/wait.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.50.x    #5499      +/-   ##
===================================================
- Coverage            25.75%   25.73%   -0.02%     
===================================================
  Files                  445      445              
  Lines                48021    48059      +38     
===================================================
+ Hits                 12366    12370       +4     
- Misses               34687    34720      +33     
- Partials               968      969       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit 8ff25b1 into release-v0.50.x Jan 21, 2025
15 of 17 checks passed
@Warashi Warashi deleted the cherry-pick-#5424-#5425-#5443-#5461-#5464-#5498-to-release-v0.50.x branch January 21, 2025 05:03
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants