[ECS] Enabled to configure/update PropagateTags and EnableECSManagedTags
#5425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
=======================================
Coverage 25.95% 25.96%
=======================================
Files 451 451
Lines 48799 48801 +2
=======================================
+ Hits 12665 12669 +4
+ Misses 35127 35126 -1
+ Partials 1007 1006 -1 ☔ View full report in Codecov by Sentry. |
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…edTags` (#5425) * Enable updating PropagateTags and specifying other than SERVICE Signed-off-by: t-kikuc <[email protected]> * Enable updating EnableECSManagedTags Signed-off-by: t-kikuc <[email protected]> * Remove default PropagateTags: unnecessary Signed-off-by: t-kikuc <[email protected]> * support propagateTags other than SERVICE Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
Warashi
added a commit
that referenced
this pull request
Jan 21, 2025
* [ECS] Support 5 missing fields in TaskDefinition (#5424) * Add missing fields in RegisterTaskDef Signed-off-by: t-kikuc <[email protected]> * remove two restrictions Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * [ECS] Enabled to configure/update `PropagateTags` and `EnableECSManagedTags` (#5425) * Enable updating PropagateTags and specifying other than SERVICE Signed-off-by: t-kikuc <[email protected]> * Enable updating EnableECSManagedTags Signed-off-by: t-kikuc <[email protected]> * Remove default PropagateTags: unnecessary Signed-off-by: t-kikuc <[email protected]> * support propagateTags other than SERVICE Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Enhance logging in EventWatcher (#5443) * Add logger.Error() before returning for detailed logs Signed-off-by: t-kikuc <[email protected]> * Enhance error logging in event watcher with additional context for push and commit failures Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * fixed to certainly store the startTime (#5461) Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Add default envs in ScriptRunStage: SR_TRIGGERED_COMMANDER, SR_IS_ROLLBACK (#5464) * Add TriggeredCommandar Signed-off-by: t-kikuc <[email protected]> * add isRollback Signed-off-by: t-kikuc <[email protected]> * update docs Signed-off-by: t-kikuc <[email protected]> * fix name->id Signed-off-by: t-kikuc <[email protected]> * fix env name Signed-off-by: t-kikuc <[email protected]> * fix: specify isRollback since deployment.Status is always Planned Signed-off-by: t-kikuc <[email protected]> * fix typo Signed-off-by: t-kikuc <[email protected]> * Add case of `pipectl sync` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Release v0.50.1 (#5498) Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Tetsuya KIKUCHI <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
PropagateTagsof Service on creating, not the defaultSERVICE.PropagateTagsandEnableECSManagedTagsof ServiceWhy we need it:
for 1: We don't need to force
SERVICEforPropagateTags.for 2: There's no reason to prevent updating
PropagateTagsandEnableECSManagedTags.EnableECSManagedTagshas NO effect on PipeCD managed tags.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: