-
Notifications
You must be signed in to change notification settings - Fork 5.9k
global sort,metrics: rename upload worker count metrics #61276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61276 +/- ##
================================================
+ Coverage 73.1714% 73.5422% +0.3707%
================================================
Files 1726 1726
Lines 478241 479750 +1509
================================================
+ Hits 349936 352819 +2883
+ Misses 106847 105437 -1410
- Partials 21458 21494 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@fzzf678: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #61283
Problem Summary:
Actually, this panel indicate the activate upload worker count. For GCS storage we initialized some workers, so we can count the number of active uploader when uploading. But the uploader in the S3/KS3 SDK is encapsulated, and a concurrency is passed in when calling it. We cannot see how this parameter is used from outside, so the number of active uploader cannot be obtained. This problem was noticed when adding:monitoring.
tidb/br/pkg/storage/helper.go
Line 39 in d952ac5
What changed and how does it work?
To avoid misunderstanding of this metrics, we rename this panel's title as
Active parallel Upload Worker Count
and supply the valid scope in description.Check List
Tests
After this PR, the panel will display like this:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.