Skip to content

global sort,metrics: rename upload worker count metrics #61276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2025

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented May 22, 2025

What problem does this PR solve?

Issue Number: close #61283

Problem Summary:
Actually, this panel indicate the activate upload worker count. For GCS storage we initialized some workers, so we can count the number of active uploader when uploading. But the uploader in the S3/KS3 SDK is encapsulated, and a concurrency is passed in when calling it. We cannot see how this parameter is used from outside, so the number of active uploader cannot be obtained. This problem was noticed when adding:monitoring.

// For S3, we cannot get it.

What changed and how does it work?

To avoid misunderstanding of this metrics, we rename this panel's title as Active parallel Upload Worker Count and supply the valid scope in description.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    After this PR, the panel will display like this:
    image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented May 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2025
Copy link

tiprow bot commented May 22, 2025

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678 fzzf678 marked this pull request as ready for review May 23, 2025 06:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2025
@fzzf678 fzzf678 changed the title global sort,metrics: add uploader count metrics from s3/ks3 global sort,metrics: rename upload worker count metrics May 23, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5422%. Comparing base (3ceec5f) to head (75d9c62).
Report is 12 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61276        +/-   ##
================================================
+ Coverage   73.1714%   73.5422%   +0.3707%     
================================================
  Files          1726       1726                
  Lines        478241     479750      +1509     
================================================
+ Hits         349936     352819      +2883     
+ Misses       106847     105437      -1410     
- Partials      21458      21494        +36     
Flag Coverage Δ
integration 42.5626% <ø> (?)
unit 72.4320% <ø> (-0.0045%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.9848% <ø> (-0.6149%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

ti-chi-bot bot commented May 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2025
Copy link

ti-chi-bot bot commented May 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-23 06:57:05.017364726 +0000 UTC m=+16050.962629536: ☑️ agreed by tangenta.
  • 2025-05-23 08:25:47.288223079 +0000 UTC m=+21373.233487889: ☑️ agreed by CbcWestwolf.

Copy link

tiprow bot commented May 23, 2025

@fzzf678: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 75d9c62 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 5a3bf79 into pingcap:master May 23, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel Upload Worker Count is missing in s3/ks3
3 participants