planner: add MPPSink interface for later MPP CTE support #61252
Conversation
ti-chi-bot
bot
added
release-note-none
| @@ -52,7 +53,7 @@ type Fragment struct { | |||
| CTEReaders []*PhysicalCTE // The receivers for CTE storage/producer. | |||
|
|
|||
| // following fields are filled after scheduling. | |||
| ExchangeSender *PhysicalExchangeSender // data exporter | |||
| Sink MPPSink // data exporter | |||
There was a problem hiding this comment.
This name is to be compatible with tiflash's concept Sink and Source.
Other names are welcome.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61252 +/- ##
================================================
+ Coverage 73.1802% 73.5213% +0.3410%
================================================
Files 1726 1727 +1
Lines 478091 485360 +7269
================================================
+ Hits 349868 356843 +6975
- Misses 106781 107050 +269
- Partials 21442 21467 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
| @@ -52,7 +53,7 @@ type Fragment struct { | |||
| CTEReaders []*PhysicalCTE // The receivers for CTE storage/producer. | |||
|
|
|||
| // following fields are filled after scheduling. | |||
| ExchangeSender *PhysicalExchangeSender // data exporter | |||
| Sink MPPSink // data exporter | |||
There was a problem hiding this comment.
seems a internal interface name, if it won't be in the explain, i think its fine
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: ref #61239
Problem Summary:
What changed and how does it work?
to support the new cte operator on mpp side.
the top operator of each fragment can have multiple choices, not only the current
ExchangeSender.so this pr is to abstract an interface for later use.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.