Skip to content

executor: update internal mpp tasks waitReport time from 3s to 100ms #61235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented May 21, 2025

What problem does this PR solve?

Issue Number: close #61233

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Check
explain analyze select o_orderkey, o_custkey from orders where o_comment like "%%" limit 5;
+--------------------------------+---------+---------+--------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------+---------+------+
| id                             | estRows | actRows | task         | access object | execution info                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 | operator info                                                                      | memory  | disk |
+--------------------------------+---------+---------+--------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------+---------+------+
| Limit_11                       | 5.00    | 5       | root         |               | time:16.5ms, open:399.1µs, close:8.28ms, loops:2, RU:1031.32                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   | offset:0, count:5                                                                  | N/A     | N/A  |
| └─TableReader_26               | 5.00    | 1024    | root         |               | time:16.5ms, open:395.8µs, close:8.24ms, loops:1, cop_task: {num: 1, max: 0s, proc_keys: 0, copr_cache_hit_ratio: 0.00}, fetch_resp_duration: 7.82ms                                                                                                                                                                                                                                                                                                                                                                                                                                                                           | MppVersion: 3, data:ExchangeSender_25                                              | 1.00 MB | N/A  |
|   └─ExchangeSender_25          | 5.00    | 262144  | mpp[tiflash] |               | tiflash_task:{time:15.1ms, loops:4, threads:12}, tiflash_network: {inner_zone_send_bytes: 2100236}                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             | ExchangeType: PassThrough                                                          | N/A     | N/A  |
|     └─Projection_14            | 5.00    | 262144  | mpp[tiflash] |               | tiflash_task:{time:14ms, loops:4, threads:12}                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  | test.orders.o_orderkey, test.orders.o_custkey                                      | N/A     | N/A  |
|       └─Selection_24           | 5.00    | 262144  | mpp[tiflash] |               | tiflash_task:{time:13.9ms, loops:4, threads:12}                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                | like(test.orders.o_comment, "%%", 92)                                              | N/A     | N/A  |
|         └─TableFullScan_23     | 6.25    | 262144  | mpp[tiflash] | table:orders  | tiflash_task:{time:13.4ms, loops:4, threads:12}, tiflash_scan:{mvcc_input_rows:0, mvcc_input_bytes:0, mvcc_output_rows:0, local_regions:1, remote_regions:0, tot_learner_read:0ms, region_balance:{instance_num: 1, max/min: 1/1=1.000000}, delta_rows:0, delta_bytes:0, segments:3, stale_read_regions:0, tot_build_snapshot:0ms, tot_build_bitmap:0ms, tot_build_inputstream:0ms, min_local_stream:5ms, max_local_stream:12ms, dtfile:{data_scanned_rows:1016672, data_skipped_rows:0, mvcc_scanned_rows:0, mvcc_skipped_rows:0, lm_filter_scanned_rows:0, lm_filter_skipped_rows:0, tot_rs_index_check:0ms, tot_read:23ms}} | pushed down filter:empty, keep order:false, stats:partial[o_comment:unInitialized] | N/A     | N/A  |
+--------------------------------+---------+---------+--------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------+---------+------+
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2025
Copy link

tiprow bot commented May 21, 2025

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented May 21, 2025

/cc @windtalker @xzhangxian1008

@ti-chi-bot ti-chi-bot bot requested review from windtalker and xzhangxian1008 May 21, 2025 07:55
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2025
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2025
Copy link

ti-chi-bot bot commented May 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-21 07:57:55.624457207 +0000 UTC m=+162112.725624429: ☑️ agreed by xzhangxian1008.
  • 2025-05-21 08:14:00.285523715 +0000 UTC m=+163077.386690934: ☑️ agreed by windtalker.

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.0240%. Comparing base (51659f3) to head (5a78211).
Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61235        +/-   ##
================================================
+ Coverage   73.1386%   74.0240%   +0.8853%     
================================================
  Files          1726       1726                
  Lines        478048     482253      +4205     
================================================
+ Hits         349638     356983      +7345     
+ Misses       106960     103932      -3028     
+ Partials      21450      21338       -112     
Flag Coverage Δ
integration 43.3128% <0.0000%> (?)
unit 72.9035% <0.0000%> (+0.5286%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.7673% <ø> (+0.1922%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

tiprow bot commented May 21, 2025

@yibin87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 5a78211 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yibin87
Copy link
Contributor Author

yibin87 commented May 21, 2025

/test mysql-test

Copy link

tiprow bot commented May 21, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented May 21, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@yibin87
Copy link
Contributor Author

yibin87 commented May 22, 2025

/test mysql-test

@yibin87
Copy link
Contributor Author

yibin87 commented May 22, 2025

/test unit-test

Copy link

tiprow bot commented May 22, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented May 22, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented May 22, 2025

/test unit-test

@yibin87
Copy link
Contributor Author

yibin87 commented May 22, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
Copy link

tiprow bot commented May 22, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented May 23, 2025

/test unit-test

Copy link

tiprow bot commented May 23, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 29758db into pingcap:master May 23, 2025
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust limit mpp tasks' receiveReportTimeout
3 participants