-
Notifications
You must be signed in to change notification settings - Fork 5.9k
planner: Support brief format for explain for connection
#61230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @King-Dylan. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @King-Dylan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61230 +/- ##
================================================
+ Coverage 73.1779% 73.6561% +0.4782%
================================================
Files 1726 1726
Lines 478091 478192 +101
================================================
+ Hits 349857 352218 +2361
+ Misses 106787 104497 -2290
- Partials 21447 21477 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
pkg/util/processinfo.go
Outdated
@@ -67,6 +67,7 @@ type ProcessInfo struct { | |||
ResourceGroupName string | |||
SessionAlias string | |||
RedactSQL string | |||
BinaryPlan string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but how about renaming it to BriefBinaryPlan
?
/retest |
What problem does this PR solve?
Issue Number: close #60965
Problem Summary:
What changed and how does it work?
This PR fixes the incorrect behavior of EXPLAIN FORMAT='brief' FOR CONNECTION, which previously did not produce the expected output. The fix works by saving the binary execution plan directly when setting processinfo. Later, when EXPLAIN FORMAT='brief' FOR CONNECTION is executed, it decodes the stored binary plan to produce the correct and consistent output.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.