Skip to content

planner: Support brief format for explain for connection #61230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

King-Dylan
Copy link
Contributor

@King-Dylan King-Dylan commented May 21, 2025

What problem does this PR solve?

Issue Number: close #60965

Problem Summary:

What changed and how does it work?

This PR fixes the incorrect behavior of EXPLAIN FORMAT='brief' FOR CONNECTION, which previously did not produce the expected output. The fix works by saving the binary execution plan directly when setting processinfo. Later, when EXPLAIN FORMAT='brief' FOR CONNECTION is executed, it decodes the stored binary plan to produce the correct and consistent output.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2025
Copy link

ti-chi-bot bot commented May 21, 2025

Hi @King-Dylan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label May 21, 2025
Copy link

tiprow bot commented May 21, 2025

Hi @King-Dylan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label May 21, 2025
@qw4990
Copy link
Contributor

qw4990 commented May 21, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.6561%. Comparing base (ced609b) to head (e00463e).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61230        +/-   ##
================================================
+ Coverage   73.1779%   73.6561%   +0.4782%     
================================================
  Files          1726       1726                
  Lines        478091     478192       +101     
================================================
+ Hits         349857     352218      +2361     
+ Misses       106787     104497      -2290     
- Partials      21447      21477        +30     
Flag Coverage Δ
integration 42.6816% <44.9275%> (?)
unit 72.4554% <69.5652%> (+0.0215%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.5969% <ø> (+0.0218%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

ti-chi-bot bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 21, 2025
Copy link

ti-chi-bot bot commented May 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-21 17:35:06.945051829 +0000 UTC m=+27411.362111391: ☑️ agreed by qw4990.

@@ -67,6 +67,7 @@ type ProcessInfo struct {
ResourceGroupName string
SessionAlias string
RedactSQL string
BinaryPlan string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but how about renaming it to BriefBinaryPlan?

@King-Dylan
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain for connection doesn't have the brief format
2 participants