Skip to content

Migrate from tslint (unsupported) to ESLint #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Migrate from tslint (unsupported) to ESLint #433

merged 1 commit into from
May 7, 2025

Conversation

omkar-ethz
Copy link
Member

Migrate from TSLint (deprecated) to ESLint following this guide. ng lint now runs and reports some errors and warnings. Also shown while editing in VSCode.

Current output of ng lint (last few lines):

✖ 85 problems (48 errors, 37 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

Lint warnings found in the listed files.

Lint errors found in the listed files.

@omkar-ethz omkar-ethz requested a review from minottic May 6, 2025 14:25
@omkar-ethz omkar-ethz mentioned this pull request May 6, 2025
Copy link
Member

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor comment. thanks for the change

"typescript": "~4.9.5"
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

@omkar-ethz omkar-ethz merged commit ead4268 into main May 7, 2025
1 check passed
@omkar-ethz omkar-ethz deleted the eslint branch May 7, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants