Upgrade Angular to v16

[omkar-ethz]

1. Upgrade Angular, and Angular Material (and some other dependencies to v16. Tests pass and the UI looks like before --> Not migrated Material Legacy components to MDC components yet, will do so in separate PR as part of v17 migration.
2. Fix appearance of toolbar (the API seems to have changed and color needs to be passed as a property rather than CSS attribute)

[Copilot]

Pull Request Overview

This PR updates the linting toolchain and upgrades Angular and Angular Material to version 16, while also fixing the toolbar appearance by updating its API usage.

• Migrated from TSLint to ESLint following the guide.
• Upgraded Angular and Angular Material to v16.
• Adjusted the toolbar component to use the new API by passing the color as a property.

Reviewed Changes

Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.

File	Description
scilog/src/app/logbook/core/navigation-guard-service.ts	Removed the implementation of the CanDeactivate interface; review whether this change aligns with intended route guard behavior.
scilog/src/app/core/toolbar/toolbar.component.html	Updated the toolbar component to include a color property as required by Angular Material v16.

Files not reviewed (5)

• scilog/.eslintrc.json: Language not supported
• scilog/angular.json: Language not supported
• scilog/package.json: Language not supported
• scilog/src/app/core/toolbar/toolbar.component.scss: Language not supported
• scilog/tslint.json: Language not supported

[Copilot]

The removal of the 'CanDeactivate' interface implementation might bypass Angular's type safety for route guards. If the intention is to maintain the guard's contract for the router, consider re-adding 'implements CanDeactivate'.

[minottic]

thanks! would you mind keeping the ESLINT change to another PR that we will merge before this?

has the look changed already anywhere (a part from the toolbar fix)?

[Copilot]

Pull Request Overview

This PR upgrades Angular and Angular Material to v16 and adds linting while fixing the toolbar appearance by adapting to the updated API.

• Upgraded Angular dependencies to v16.
• Adjusted toolbar component to use the new 'color' property for .
• Modified the NavigationGuardService, notably removing the explicit CanDeactivate implementation.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File	Description
scilog/src/app/logbook/core/navigation-guard-service.ts	Removed interface implementation from NavigationGuardService which may affect Angular route guard behavior.
scilog/src/app/core/toolbar/toolbar.component.html	Updated with a "color" property to meet the new API requirements.

Files not reviewed (2)

• scilog/package.json: Language not supported
• scilog/src/app/core/toolbar/toolbar.component.scss: Language not supported

Comments suppressed due to low confidence (1)

scilog/src/app/logbook/core/navigation-guard-service.ts:10

• Removing the 'CanDeactivate' interface from NavigationGuardService may impact its role as an Angular route guard. Please confirm that this change is intentional and that the guard behavior is maintained with Angular v16.

export class NavigationGuardService  {

[omkar-ethz]

thanks! would you mind keeping the ESLINT change to another PR that we will merge before this?

has the look changed already anywhere (a part from the toolbar fix)?

@minottic thank you for having a look! The look hasn't changed at all as far as I can tell.
Good point, created a separate PR for eslint: #433

Updated this PR's base branch as the eslint branch, as the ng update command updates eslint from 15 to 16 as well.

[minottic]

looks good! Is the copilot warning relevant?

[omkar-ethz]

looks good! Is the copilot warning relevant?

It is kind of relevant -- thanks! Angular recommends moving to functional guards, so had deprecated the class based CanDeactivate interface. But in the router we were still using class based approach. Fixed this in the latest commit. Minor enough that I think i don't need to request a re-review, will merge!