Updates partiql-eval public API and internal classes #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5372 Number failing in both: 434 Number passing in Base (941a760) but now fail: 0 Number failing in Base (941a760) but now pass: 12 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
rchowell
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## partiql-eval #1287 +/- ##
===============================================
Coverage ? 49.23%
Complexity ? 1045
===============================================
Files ? 166
Lines ? 13392
Branches ? 2500
===============================================
Hits ? 6593
Misses ? 6144
Partials ? 655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fix typer path navigation
* fix timestamp type parsing issue
johnedquinn
requested changes
Dec 8, 2023
| @@ -45,7 +45,7 @@ val elements: List<AnyElement> = loadAllElements("type::{ name: foo }") | |||
| val parsedSchemaModel: IonSchemaModel.Model = parseSchema(elements) | |||
| ``` | |||
|
|
|||
| Alternatively, users can parse `ion-schema-kotlin` [Schema](https://github.com/amzn/ion-schema-kotlin/blob/master/src/com/amazon/ionschema/Schema.kt#L36) | |||
| Alternatively, users can parse `ion-schema-kotlin` [Schema](https://github.com/amzn/ion-schema-kotlin/blob/master/src/com/amazon/ionschema/Namespace.kt#L36) | |||
There was a problem hiding this comment.
This URL doesn't work. Not blocking though, since the old URL didn't work as well.
There was a problem hiding this comment.
Non-blocking, this was left behind.
Comment on lines
68
to
80
| @OptIn(PartiQLValueExperimental::class) | ||
| public class MyInt32Plus : PartiQLFunction.Scalar { | ||
|
|
||
| override val signature: FunctionSignature.Scalar = TODO("Not yet implemented") | ||
|
|
||
| override fun invoke(args: Array<PartiQLValue>): PartiQLValue { | ||
| val arg0 = args[0].check<Int32Value>().value | ||
| val arg1 = args[1].check<Int32Value>().value | ||
| if (arg0 == null || arg1 == null) { | ||
| return int32Value(null) | ||
| } | ||
| return int32Value(arg0 + arg1) | ||
| } |
Adds support for EXCLUDE in the default SqlDialect
- comment out subsumption tests (to be added in #1280)
rchowell
force-pushed
the
partiql-eval-interfaces
branch
from
7c0af6e to
46b98c0
Compare
johnedquinn
approved these changes
Dec 8, 2023
alancai98
added a commit
that referenced
this pull request
Dec 12, 2023
--------- Co-authored-by: John Ed Quinn <[email protected]> Co-authored-by: Yingtao Liu <[email protected]> Co-authored-by: yliuuuu <[email protected]> Co-authored-by: John Ed Quinn <[email protected]> Co-authored-by: Alan Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates partiql-eval interfaces
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.