Skip to content

fix typer/transfomrer #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix typer/transfomrer #1288

merged 1 commit into from
Dec 8, 2023

Conversation

yliuuuu
Copy link
Contributor

@yliuuuu yliuuuu commented Dec 8, 2023

Relevant Issues

  • [Closes/Related To] Issue #XXX

Description

  • We need explicitly override the visitRexOpPathStep in the typer as in some case we need the resolved node as the step. i.e., the path step is a call node
  • The Typer should throw an problem code upon encounter an unresolved function. Hence in PlanTransform we can just error out.
    • I am not sure what is the purpose of the error node in the resolved plan. If we don't need this, I can have a follow up PR to remove it.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]

    • No.
  • Any backward-incompatible changes? [YES/NO]

    • No.
  • Any new external dependencies? [YES/NO]

    • No.
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    No.

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Dec 8, 2023

Conformance comparison report

Base (f8f6b2a) 1f1f5c8 +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (f8f6b2a) but now fail: 0

Number failing in Base (f8f6b2a) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8f6b2a) 72.20% compared to head (a07b6aa) 72.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1288   +/-   ##
=========================================
  Coverage     72.20%   72.20%           
  Complexity     2100     2100           
=========================================
  Files           222      222           
  Lines         16019    16019           
  Branches       2891     2891           
=========================================
  Hits          11567    11567           
  Misses         3635     3635           
  Partials        817      817           
Flag Coverage Δ
CLI 13.43% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rchowell rchowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to error out because we want to collect all plan errors. I'm not sure the best way go here. Ideally we don't have an error node, but I don't think we can throw?

I'm approving because I think throwing is better than having a hidden error node in the resolved plan

@yliuuuu yliuuuu merged commit 6ba5a12 into main Dec 8, 2023
@yliuuuu yliuuuu deleted the path-navi-with-function branch December 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants