Skip to content

Add thermal parameters to worlds #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 11, 2021
Merged

Add thermal parameters to worlds #787

merged 12 commits into from
Feb 11, 2021

Conversation

angelacmaio
Copy link
Contributor

Adds the <atmosphere> tag with thermal properties for each world. In this PR, all worlds are set to:

<atmosphere type="adiabatic">
    <temperature>288</temperature>
    <temperature_gradient>0.2</temperature_gradient>
</atmosphere>

The gradient currently affects both temperature variation over altitude (K/m) and in-scene temperature variation. Soon, this should be broken out into separate parameters via a new plugin, so we can keep approximately this level of in-scene temperature variation and reduce the altitude-based variation.

@iche033 @nkoenig can you take a look?

@osrf-jenkins
Copy link

Build finished. No test results found.

@nkoenig nkoenig merged commit 6bd98e3 into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants