-
Notifications
You must be signed in to change notification settings - Fork 100
New features for Absolem robot. #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These new features will not be incorporated into the SubT Virtual Testbed prior to Cave Circuit. We will keep this PR open for consideration after Cave Circuit. |
I know, that's okay ;) |
The bounding box for this model is
|
7c8747b
to
fe3369c
Compare
I rebased on master and this PR is ready for review. |
Review could be easier commit-by-commit as I kept distinct features separate. To test the relative positional control:
Further, the model now respects the
|
Build finished. No test results found. |
…eleting the ECM shim from this package.
Build finished. No test results found. |
I've updated this branch with master (no conflict) and simplified ECM handling by gazebosim/gz-sim#629 (released with ign-gazebo 4.6.0). |
# Conflicts: # submitted_models/ctu_cras_norlab_absolem_sensor_config_1/src/flipper_control_plugin.cpp
Tested out position, relative position, and velocity control with no adverse interactions on my system. |
@acschang Can you give this one more pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM. I don't see any adverse behavior with other functionality from the small set of tests I did.
Also, in peci1's example for velocity control, use the following:
rostopic pub /X1/flippers_cmd_vel/front_right std_msgs/Float64 "data: -1.5"
rostopic echo /X1/joint_state/velocity[3]
This PR depends on #542.
New features were added to the Absolem robot model:
<joint><limits>
are now respected by the flipper controller