Skip to content

[GR-60649] [GR-61423] Various fixes for system properties and locales. #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Feb 3, 2025

  • Fixed crashes related to the locale support.
  • Fixed memory leaks in the locale support.
  • Added proper error handling to the locale C implementation.
  • Refactored the locale-related interface between Java and C.
  • Added a proper @CStruct for LocaleProps (before, we wrongly assumed that the C compiler needs to use a certain layout for the struct)
  • Fixed the #ifdefs in locale.c so that more code is excluded on Windows.
  • Fixed various issues where the locale support in Native Image would behave differently from the one in HotSpot (especially related to the defaulting logic in SystemProps.fillI18nProps(...)).
  • The locale support is now only initialized once per process (instead of multiple times per isolate).
  • Disabled locale support for libgraal (see option UseSystemLocale).
  • Deprecated the API function ProcessProperties.setLocale(...) as it is inherently unsafe.
  • Fixed incomplete @BasedOnJDKFile annotations for the locale support.
  • Fixed various issues where we initialized all lazy system properties even though only a single system property was requested.
  • Fixed various race conditions in SystemPropertiesSupport.
  • Fixed a ConcurrentModificationException in the SystemPropertiesSupport that could happen with multi-threading.
  • Fixed user.region handling in Target_jdk_internal_util_StaticProperty.
  • Fixed Target_jdk_internal_util_StaticProperty.USER_LANGUAGE_FORMAT which contained a wrong value.
  • Fixed Target_jdk_internal_util_StaticProperty.javaHome(), osName(), osArch(), and osVersion().
  • Fixed the value of the system property os.arch on Darwin.
  • Marked all fields that should not be reachable at runtime with @Delete in Target_jdk_internal_util_StaticProperty (they contain problematic hosted values).
  • Removed some no longer needed code (leftover from JDK 11).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 3, 2025
@graalvmbot graalvmbot closed this Feb 3, 2025
@graalvmbot graalvmbot deleted the chaeubl/GR-60649 branch February 3, 2025 22:41
@graalvmbot graalvmbot merged commit e6ed2f0 into master Feb 3, 2025
13 checks passed
zakkak added a commit to zakkak/mandrel-packaging that referenced this pull request Feb 4, 2025
zakkak added a commit to graalvm/mandrel-packaging that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants