-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bump op-primer-view-component to 0.68.0 #19026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump op-primer-view-component to 0.68.0 #19026
Conversation
1768452
to
86a8217
Compare
There are two tests, that expect the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the testing approach here - I've made some suggetions.
modules/auth_saml/spec/features/administration/saml_crud_spec.rb
Outdated
Show resolved
Hide resolved
modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the have_heading
check, I did not know about this one. Good catch @myabc 👏
Ticket
https://community.openproject.org/wp/64228
What are you trying to accomplish?
Update OP Core with new version of OP primer-view-components