Skip to content

Bump op-primer-view-component to 0.68.0 #19026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bsatarnejad
Copy link
Contributor

Ticket

https://community.openproject.org/wp/64228

What are you trying to accomplish?

Update OP Core with new version of OP primer-view-components

@bsatarnejad bsatarnejad force-pushed the 64228-home-screen-widgets-have-the-wrong-headline-tag-update-core-with-primer-repo branch from 1768452 to 86a8217 Compare May 26, 2025 14:49
@HDinger
Copy link
Contributor

HDinger commented May 27, 2025

There are two tests, that expect the old h1 tag and need to be updated. Otherwise, good to merge 👍

Copy link
Contributor

@myabc myabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the testing approach here - I've made some suggetions.

Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the have_heading check, I did not know about this one. Good catch @myabc 👏

@HDinger HDinger merged commit 25f61a6 into dev May 27, 2025
15 checks passed
@HDinger HDinger deleted the 64228-home-screen-widgets-have-the-wrong-headline-tag-update-core-with-primer-repo branch May 27, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants