Skip to content

Commit 25f61a6

Browse files
authored
Bump op-primer-view-component to 0.68.0 (#19026)
* update core with new primer view components version * change h1 to h2 in news test for page header title * fix failing test in files page header * fix failing test in saml providers page header * fix failing test in my page page header * fix failing test in meetings page header * use have_heading instead of test selector * use have_heading instead of test selector * use have-heading in storages test
1 parent 7c61f16 commit 25f61a6

File tree

12 files changed

+33
-31
lines changed

12 files changed

+33
-31
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,4 +417,4 @@ end
417417

418418
gem "openproject-octicons", "~>19.25.0"
419419
gem "openproject-octicons_helper", "~>19.25.0"
420-
gem "openproject-primer_view_components", "~>0.67.0"
420+
gem "openproject-primer_view_components", "~>0.68.0"

Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,7 @@ GEM
856856
actionview
857857
openproject-octicons (= 19.25.0)
858858
railties
859-
openproject-primer_view_components (0.67.0)
859+
openproject-primer_view_components (0.68.0)
860860
actionview (>= 7.1.0)
861861
activesupport (>= 7.1.0)
862862
openproject-octicons (>= 19.25.0)
@@ -1445,7 +1445,7 @@ DEPENDENCIES
14451445
openproject-octicons (~> 19.25.0)
14461446
openproject-octicons_helper (~> 19.25.0)
14471447
openproject-openid_connect!
1448-
openproject-primer_view_components (~> 0.67.0)
1448+
openproject-primer_view_components (~> 0.68.0)
14491449
openproject-recaptcha!
14501450
openproject-reporting!
14511451
openproject-storages!
@@ -1817,7 +1817,7 @@ CHECKSUMS
18171817
openproject-octicons (19.25.0) sha256=16fc221375e693f0e893b1c208286f2d7719ae4dfe080c5415642b221f51f550
18181818
openproject-octicons_helper (19.25.0) sha256=9b1778a67b0015ebe84ca0471f74e31004b985a8dcaaa443f7a2ac365b0a4e2d
18191819
openproject-openid_connect (1.0.0)
1820-
openproject-primer_view_components (0.67.0) sha256=5cfe9eb0fa86498ebe44e78482fa4e80aa305edd0d3d183a0ddb8cc2d693b1c9
1820+
openproject-primer_view_components (0.68.0) sha256=847cc5e0e2933e3c34f6106c6bb6b68d4563ef649401a59e794660b4aa50c47f
18211821
openproject-recaptcha (1.0.0)
18221822
openproject-reporting (1.0.0)
18231823
openproject-storages (1.0.0)

frontend/package-lock.json

Lines changed: 16 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@
102102
"@ngneat/content-loader": "^7.0.0",
103103
"@ngx-formly/core": "^6.1.4",
104104
"@openproject/octicons-angular": "^19.25.0",
105-
"@openproject/primer-view-components": "^0.67.0",
105+
"@openproject/primer-view-components": "^0.68.0",
106106
"@openproject/reactivestates": "^3.0.1",
107107
"@primer/css": "^21.5.0",
108108
"@primer/live-region-element": "^0.8.0",
109109
"@primer/primitives": "^9.1.2",
110-
"@primer/view-components": "npm:@openproject/primer-view-components@^0.67.0",
110+
"@primer/view-components": "npm:@openproject/primer-view-components@^0.68.0",
111111
"@types/hotwired__turbo": "^8.0.1",
112112
"@uirouter/angular": "^13.0.0",
113113
"@uirouter/core": "^6.1.0",

modules/auth_saml/spec/features/administration/saml_crud_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
fill_in "Name", with: "My provider"
4848
click_link_or_button "Continue"
4949

50-
expect(page).to have_css("h1", text: "My provider")
50+
expect(page).to have_heading text: "My provider"
5151

5252
# Skip metadata
5353
click_link_or_button "Continue"

modules/meeting/spec/features/recurring_meetings/recurring_meeting_global_create_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
meetings_page.click_create
7979
wait_for_network_idle
8080

81-
expect(page).to have_css("h1", text: "Some title")
81+
expect(page).to have_heading "Some title"
8282
meeting = Meeting.last
8383
expect(meeting.title).to eq "Some title"
8484
expect(meeting.project).to eq project
@@ -105,7 +105,7 @@
105105
meetings_page.click_create
106106
wait_for_network_idle
107107

108-
expect(page).to have_css("h1", text: "Some title (Template)")
108+
expect(page).to have_heading "Some title (Template)"
109109
meeting = Meeting.last
110110
expect(meeting.title).to eq "Some title"
111111
expect(meeting.project).to eq project

modules/meeting/spec/features/structured_meetings/structured_meeting_global_crud_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
meetings_page.click_create
111111
wait_for_network_idle
112112

113-
expect(page).to have_css("h1", text: "Some title")
113+
expect(page).to have_heading "Some title"
114114
meeting = Meeting.last
115115
expect(meeting.title).to eq "Some title"
116116
expect(meeting.project).to eq project

modules/my_page/spec/features/my/my_page_navigation_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
find("#main-menu #{test_selector('op-menu--item-action')}", text: "My page").click
4545

4646
expect(page).to have_current_path "/my/page"
47-
expect(page).to have_css("h1", text: "My page")
47+
expect(page).to have_heading text: "My page"
4848
expect(page).to have_css("#main-menu #{test_selector('op-menu--item-action')}.selected")
4949
end
5050
end

modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
visit external_file_storages_project_settings_project_storages_path(project)
7070

7171
# The list of enabled file storages should now contain Storage 1
72-
expect(page).to have_css("h1", text: "Files")
72+
expect(page).to have_heading "Files"
7373
expect(page).to have_text("Storage 1")
7474

7575
# Press Delete icon to remove the storage from the project

modules/storages/spec/features/manage_project_storage_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@
138138
expect_and_dismiss_flash(message: "Successful creation.")
139139

140140
# The list of enabled file storages should now contain Storage 1
141-
expect(page).to have_css("h1", text: "Files")
141+
expect(page).to have_heading "Files"
142142
expect(page).to have_text(storage.name)
143143

144144
# Press Edit icon to change the project folder mode to inactive
@@ -161,7 +161,7 @@
161161
expect_and_dismiss_flash(message: "Successful update.")
162162

163163
# The list of enabled file storages should still contain Storage 1
164-
expect(page).to have_css("h1", text: "Files")
164+
expect(page).to have_heading "Files"
165165
expect(page).to have_text(storage.name)
166166

167167
# Click Edit icon again but cancel the edit

modules/storages/spec/features/storages/project_settings/oauth_access_grant_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
expect(page).to have_checked_field("New folder with automatically managed permissions")
7777
click_on("Add")
7878

79-
expect(page).to have_css("h1", text: "Files")
79+
expect(page).to have_heading "Files"
8080
expect(page).to have_text(storage.name)
8181

8282
within_test_selector("oauth-access-grant-nudge-modal") do

spec/controllers/news_controller_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
expect(response).to be_successful
6868
expect(response).to render_template "show"
6969

70-
expect(response.body).to have_css("h1", text: news.title)
70+
expect(assigns(:news)).to eq news
7171
end
7272

7373
it "renders show with slug" do
@@ -76,7 +76,7 @@
7676
expect(response).to be_successful
7777
expect(response).to render_template "show"
7878

79-
expect(response.body).to have_css("h1", text: news.title)
79+
expect(assigns(:news)).to eq news
8080
end
8181

8282
it "renders error if news item is not found" do

0 commit comments

Comments
 (0)