ipi/deprovision/deprovision: Remove stuttering subdirectory #7931

wking · 2020-03-25T21:18:17Z

The directory was from 23ca2ce (#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.

wking · 2020-03-25T21:24:27Z

Pushed a6db4077a to do the same for ipi/install/install.

stevekuznetsov · 2020-03-25T21:38:54Z

 .//ci-operator/step-registry/ipi/install/vsphere/ipi-install-vsphere-commands.sh: .//ci-operator/step-registry/ipi/install/vsphere/ipi-install-vsphere-commands.sh: openBinaryFile: does not exist (No such file or directory)

We may need to update that ShellCheck job

openshift-bot · 2020-03-25T21:43:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-03-25T21:47:41Z

/hold

While I work through rehearsal:

time="2020-03-25T21:45:15Z" level=error msg="could not load step registry" error="Failed to load registry file ci-operator/step-registry/ipi/install/ipi-install-install-ref.yaml: open ci-operator/step-registry/ipi/install/ipi-install-commands.sh: no such file or directory" pr=7931
ERROR: pj-rehearse: misconfiguration

openshift-ci-robot · 2020-03-25T21:49:22Z

New changes are detected. LGTM label has been removed.

wking · 2020-03-25T21:49:40Z

Should be fixed with a6db4077a -> 12e2732bc.

/hold cancel

stevekuznetsov · 2020-03-25T22:00:01Z

shellcheck still no likey

wking · 2020-03-25T22:24:28Z

Ah, fixed the symlink (and rebased on master, no conflicts) with 12e2732bc -> 04658519e.

wking · 2020-03-25T22:39:44Z

pj-rehearse says:

time="2020-03-25T22:25:28Z" level=error msg="could not get step registry differences" error="could not find registry component in registry graph: ipi-install-install" pr=7931
ERROR: pj-rehearse: misconfiguration

But:

$ git --no-pager log -1 --oneline
04658519e (HEAD -> drop-deprovision-stutter, wking/drop-deprovision-stutter) ipi/install/install: Remove stuttering subdirectory
$ git --no-pager grep install-install 04658519e --
...no hits...

Maybe stale branch?

/retest

wking · 2020-03-25T23:00:57Z

Fixed the ipi-install-install-ref.yaml filename with 04658519e -> 2c8bb98

wking · 2020-03-25T23:35:26Z

@AlexNPavel on using the same name for both a ref and chain:

Essentially, the issue with this is that if a ref is updated and a chain has the same name, the rehearse tool will think that the chain changed, not the ref. The rehearse tool will then rehearse any jobs that have that chain anywhere in their dependency graph. The only time this could cause an issue is if a job uses the ref but not the chain, and the ref changes break that job but not jobs that use the chain.

Checking:

$ git --no-pager grep 'ref: ipi-install$' origin/pr/7931   
origin/pr/7931:ipi/install/ipi-install-chain.yaml:  - ref: ipi-install

So at least in this particular instance, we're not impacted by that limitation. Might still want to reject this PR (and unwind existing master locations where a chain and ref share a name?) to avoid setting a potentially confusing precedent?

wking · 2020-06-10T19:55:25Z

Sounds like openshift/ci-tools#818 sorted out the shared-name issue. Will reroll this PR in a bit.

wking · 2020-06-10T20:12:23Z

Rebased onto master and picked up some documentation references with 2c8bb98 -> 2c8bb98.

The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.

The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names, especially since openshift/ci-tools@dd11c766ed (rehearse,registry: make explicit maps for type in NodeByName, 2020-05-19, openshift/ci-tools#818).

wking · 2020-06-24T22:28:38Z

Rebased around #9739 with 1c6a933cc7 -> 0f7172a.

openshift-ci-robot · 2020-06-24T22:28:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/step-registry/ipi/OWNERS~~ [stevekuznetsov,wking]
~~ci-operator/step-registry/sdn/conf/multi-manifest/OWNERS~~ [stevekuznetsov]
~~ci-operator/step-registry/sdn/conf/single-manifest/OWNERS~~ [stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2020-06-25T02:04:59Z

@stevekuznetsov, tons of rehearsals, but lots are green, so my guess is the failures are unreliable in master. Should be a quick review 😇

openshift-ci-robot · 2020-07-30T15:16:37Z

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-aws	`2c8bb98`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-gcp	1c6a933cc7be68cf6a00c94b92e8adb25bd39ed2	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-azure	1c6a933cc7be68cf6a00c94b92e8adb25bd39ed2	link	`/test pj-rehearse`
ci/rehearse/opendatahub-io/odh-manifests/master/odh-manifests-e2e	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cloud-credential-operator/master/e2e-azure	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-hybrid-step-registry	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/kubernetes/marun-testing/e2e-gcp-builds	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/kubernetes/marun-testing/e2e-gcp-image-ecosystem	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/kubernetes/marun-testing/e2e-cmd	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift-knative/serverless-operator/master/4.3-e2e-aws-ocp-43	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift-knative/serverless-operator/master/4.3-upgrade-tests-aws-ocp-43	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/oc/release-4.2/e2e-cmd	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-aws-image-registry	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cluster-network-operator/master/e2e-vsphere	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cluster-network-operator/master/e2e-windows-hybrid-network	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/cluster-network-operator/master/e2e-aws-sdn-single	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-vsphere	`0f7172a`	link	`/test pj-rehearse`
ci/prow/pj-rehearse	`0f7172a`	link	`/test pj-rehearse`
ci/rehearse/openshift/builder/master/e2e-aws-builds	`0f7172a`	link	`/test pj-rehearse`
ci/prow/step-registry-metadata	`0f7172a`	link	`/test step-registry-metadata`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2020-11-10T12:00:57Z

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/release-config	`0f7172a`	link	`/test release-config`
ci/prow/boskos-config-generation	`0f7172a`	link	`/test boskos-config-generation`
ci/prow/secret-generator-config-valid	`0f7172a`	link	`/test secret-generator-config-valid`
ci/prow/deprecate-templates	`0f7172a`	link	`/test deprecate-templates`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2021-01-14T01:16:23Z

@wking: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/ci-secret-generator-config	`0f7172a`	link	`/test ci-secret-generator-config`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-14T12:59:52Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2021-04-14T12:59:58Z

@wking: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-14T16:41:56Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-06-13T19:30:04Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-06-13T19:30:12Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020

openshift-ci-robot requested review from ewolinetz and staebler March 25, 2020 21:18

stevekuznetsov approved these changes Mar 25, 2020

View reviewed changes

openshift-ci-robot assigned stevekuznetsov Mar 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020

wking force-pushed the drop-deprovision-stutter branch from a6db407 to 12e2732 Compare March 25, 2020 21:49

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020

wking force-pushed the drop-deprovision-stutter branch from 12e2732 to 0465851 Compare March 25, 2020 22:24

wking mentioned this pull request Mar 25, 2020

ci-operator/step-registry/ipi/deprovision/vsphere: Decompose into sub-steps #7935

Merged

wking force-pushed the drop-deprovision-stutter branch from 0465851 to 2c8bb98 Compare March 25, 2020 23:00

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2020

wking mentioned this pull request Jun 9, 2020

installer: use steps for e2e-{aws,azure,gcp}-shared-vpc #9517

Merged

wking force-pushed the drop-deprovision-stutter branch from 2c8bb98 to d3b9b83 Compare June 10, 2020 20:10

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2020

wking force-pushed the drop-deprovision-stutter branch from d3b9b83 to 8e4ba92 Compare June 10, 2020 20:11

wking force-pushed the drop-deprovision-stutter branch from 8e4ba92 to 1c6a933 Compare June 10, 2020 22:39

wking mentioned this pull request Jun 15, 2020

config: add periodic job that runs upgrades using multistage tests #9489

Closed

wking added 2 commits June 24, 2020 15:27

ipi/deprovision/deprovision: Remove stuttering subdirectory

2ff192b

The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names.

wking force-pushed the drop-deprovision-stutter branch from 1c6a933 to 0f7172a Compare June 24, 2020 22:28

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 14, 2021

openshift-ci bot closed this Jun 13, 2021

ipi/deprovision/deprovision: Remove stuttering subdirectory #7931

ipi/deprovision/deprovision: Remove stuttering subdirectory #7931

Uh oh!

Conversation

wking commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

stevekuznetsov commented Mar 25, 2020

Uh oh!

openshift-bot commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

openshift-ci-robot commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

stevekuznetsov commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

wking commented Mar 25, 2020

Uh oh!

wking commented Jun 10, 2020

Uh oh!

wking commented Jun 10, 2020

Uh oh!

wking commented Jun 24, 2020

Uh oh!

openshift-ci-robot commented Jun 24, 2020

Uh oh!

wking commented Jun 25, 2020

Uh oh!

openshift-ci-robot commented Jul 30, 2020

Uh oh!

openshift-merge-robot commented Nov 10, 2020

Uh oh!

openshift-ci bot commented Jan 14, 2021

Uh oh!

openshift-bot commented Apr 14, 2021

Uh oh!

openshift-ci bot commented Apr 14, 2021

Uh oh!

openshift-bot commented May 14, 2021

Uh oh!

openshift-bot commented Jun 13, 2021

Uh oh!

openshift-ci bot commented Jun 13, 2021

Uh oh!

Uh oh!