rehearse,registry: make explicit maps for type in NodeByName #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
/hold This might be causing problems in the web UI |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel That's actually an issue with go 1.14 vs go 1.13 now that I have go 1.14 on my dev laptop. Not an issue with this PR, will work on fixing that issue in a different PR |
openshift-ci-robot
removed
the
do-not-merge/hold
stevekuznetsov
approved these changes
May 20, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexNPavel, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jun 24, 2020
The directory was from 23ca2ce (Bootstrap step registry with IPI steps, 2019-11-17, openshift#5962). But chains and refs are distinct types; we don't need to use separate subdirectories to further distinguish their names, especially since openshift/ci-tools@dd11c766ed (rehearse,registry: make explicit maps for type in NodeByName, 2020-05-19, openshift/ci-tools#818).
wking
added a commit
to wking/ci-tools
that referenced
this pull request
Aug 6, 2021
Catching up with dd11c76 (rehearse,registry: make explicit maps for type in NodeByName, 2020-05-19, openshift#818).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
NodeByNametype inpkg/registryto have explicitReferences,Chains, andWorkflowsfields as well as fixes a bug in the graphs handling of nested chains.When the registry graph was first designed, it was assumed that nobody would make a chain and reference that have identical names (the
asfields). This was not enforced in the release repo, however, and it has now become convention to have both a reference and a chain called{i|u}pi-conf-cluster_typefor everycluster_typewe support. This meant that the graph would overwrite references with the same names as chains. This could potentially cause a rehearsal to not occur for jobs that use just the reference with said name instead of the chain for whatever reason. It is also simply not ideal to overwrite data unintentionally anyway.This also fixes a bug where the graph would only be able to nest one child chain per parent chain, even if there were multiple child chains. A new unit test has been added for this case.
/cc @stevekuznetsov