ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src: Drop unused template #6246
Conversation
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We probably want to drop this ci-tools code too. Or is there a UPI-src consumer I'm missing? Cluster-bot? Something magic in the ci-tools code? |
|
Looks like a lot of work, to what end? |
|
Dropping unused code looks like work? I'm trying to save us work we're currently spending on apparently dead code: $ git --no-pager log --date=short --format='%h %ad%d %s' origin/master -- ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml
9cd158adf 2019-12-03 (origin/pr/6223) template: Use a more correct kill command
dc2607523 2019-12-02 (origin/pr/6192) ci-operator/templates/openshift/installer: Bump AWS UPI to RHCOS 43.81.201911221453.0
3893cb541 2019-11-17 (origin/pr/5959) template: Increase teardown timeout
43de8a538 2019-11-16 (origin/pr/5955) template: Bump all activeDeadlineSeconds to 4 hours
866f4db0d 2019-11-03 (origin/pr/5749) ci-operator/templates: Pull AWS region and zone from the cluster for TEST_PROVIDER
8b01d7cb7 2019-10-29 (origin/pr/5649) Enable image registry for UPI & metal tests
9463bff2b 2019-10-17 (origin/pr/5495) teardown: Gather machines and machinesets on teardown of clusters
7f980d050 2019-10-16 (origin/pr/5459) Add CLI init container to UPI src template.
78d8c1733 2019-10-11 (origin/pr/5388) Add a UPI based src template. |
openshift-ci-robot
added
the
needs-rebase
…i-src: Drop unused template The template was added in 78d8c17 (Add a UPI based src template, 2019-10-11, openshift#5388), but had no consumers. There were potential consumers in flight with [1,2], but both of those pull requests closed without landing. We can always dig this back out of the Git history if it turns out folks actually do need a non-e2e UPI template, but until then remove it to save the maintenance cost of keeping unused code up to date. [1]: https://github.com/openshift/release/pull/4325/files#diff-264b567e579413709feec76ef0604cf3R336 [2]: https://github.com/openshift/release/pull/5367/files#diff-131c135812b5130dcd1252473291b4a5R188
wking
force-pushed
the
drop-upi-src-template
branch
from
2bbd0c6 to
25d8ecf
Compare
openshift-ci-robot
removed
the
needs-rebase
|
The work on that template was done to make it possible to test the Serverless product on VMSphere based environments. We kinda dropped it cause we hit issue after issue and it was said that these envs are moving to a cloud provider so we'd need a different template anyway. @mgencur can tell more. |
|
We dropped the work for Serverless on vSphere because the environment was not able to provision load balancers for Kubernetes services. I believe the work to migrate vSphere setup to AWS is still ongoing, tracked in openshift/installer#2603. I'm not sure if the code that is being removed from this openshift/release repo will work with the new installer. |
Ok, so the issue is that installer-provisioned vSphere is not a thing? And you're looking to run a custom test suite, so you can't use the upi-e2e template? |
|
@wking: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
@wking exactly so! |
|
/close |
|
@wking: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The template was added in 78d8c17 (#5388), but had no consumers. There were potential consumers in flight here and here, but both of those pull requests closed without landing. We can always dig this back out of the Git history if it turns out folks actually do need a non-e2e UPI template, but until then remove it to save the maintenance cost of keeping unused code up to date.