Add a UPI based src template. #5388
Conversation
openshift-ci-robot
added
the
size/XXL
| } | ||
| EOF | ||
| cat > /tmp/artifacts/installer/install-config.yaml << EOF | ||
| apiVersion: v1beta4 |
There was a problem hiding this comment.
@markusthoemmes apiVersion should be v1. I need to change that in the other template as well.
|
Defer to Trevor. |
This makes sense to me. But to try to keep the templates as close as possible, can we make this a series of pivots instead of one commit? For example, I don't understand what |
|
@wking that does make sense to me. I'll see if I can make this easier on the reviewers and I agree that some of these bits look like they should be in the e2e manifest anyway. |
The UPI E2E template is focused on running origin e2e tests and nothing else.
markusthoemmes
force-pushed
the
upi-src-template
branch
from
82223b0 to
78d8c17
Compare
|
Updated the template to pick up my latest commit on master. The diff between e2e and src template is now this: 12c12
< - name: IMAGE_TESTS
---
> - name: LOCAL_IMAGE_SRC
218c218
< image: ${IMAGE_TESTS}
---
> image: ${LOCAL_IMAGE_SRC}
257c257
< export PATH=/usr/libexec/origin:$PATH
---
> export PATH=/tmp/shared:$PATH
325,339d324
< mkdir -p /tmp/output
< cd /tmp/output
<
< function run-upgrade-tests() {
< openshift-tests run-upgrade "${TEST_SUITE}" --to-image "${RELEASE_IMAGE_LATEST}" \
< --provider "${TEST_PROVIDER:-}" -o /tmp/artifacts/e2e.log --junit-dir /tmp/artifacts/junit
< return 0
< }
<
< function run-tests() {
< openshift-tests run "${TEST_SUITE}" \
< --provider "${TEST_PROVIDER:-}" -o /tmp/artifacts/e2e.log --junit-dir /tmp/artifacts/junit
< return 0
< }
< |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This template has been added in openshift/release#5388.
…i-src: Drop unused template The template was added in 78d8c17 (Add a UPI based src template, 2019-10-11, openshift#5388), but had no consumers. There were potential consumers in flight with [1,2], but both of those pull requests closed without landing. We can always dig this back out of the Git history if it turns out folks actually do need a non-e2e UPI template, but until then remove it to save the maintenance cost of keeping unused code up to date. [1]: https://github.com/openshift/release/pull/4325/files#diff-264b567e579413709feec76ef0604cf3R336 [2]: https://github.com/openshift/release/pull/5367/files#diff-131c135812b5130dcd1252473291b4a5R188
The UPI E2E template is focused on running origin e2e tests and nothing else.
This is mostly a copy of the UPI E2E template, mostly copying over the test part of the
srctemplate and adjusting the top level parameters accordingly./assign @wking @jstuever