Skip to content

NO-JIRA: Support skipping [OCP]FeatureGate tests #29794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented May 15, 2025

Extends skipped tests labeled FeatureGate. Previously worked only for label OCPFeatureGate.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request explicitly references no jira issue.

In response to this:

Fix for #29760
Matches OCPFeatureGate or FeatureGate on match[1], instead of splitting it into 2 different matches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning May 15, 2025 12:24
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

Copy link
Contributor

openshift-ci bot commented May 15, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5e5d64c0-31a1-11f0-9e17-4e4031a906b2-0

@jsafrane
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview openshift/kubernetes#2270

We need the volume attributes class tests not blacklisted.

Copy link
Contributor

openshift-ci bot commented May 16, 2025

@jsafrane: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: need: string: need doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2025
@jsafrane
Copy link
Contributor

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview openshift/kubernetes#2270

Copy link
Contributor

openshift-ci bot commented May 16, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f2b03dd0-3234-11f0-8ea4-1fa80af9868f-0

@jsafrane
Copy link
Contributor

/hold
We need to check that no test gets accidentally disabled before merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@dfajmon dfajmon changed the title NO-JIRA: Fix regex to non matching group NO-JIRA: Support skipping [OCP]FeatureGate tests May 16, 2025
Copy link
Contributor

openshift-ci bot commented May 16, 2025

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-etcd-scaling 9a24e83 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive 9a24e83 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling 9a24e83 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 9a24e83 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-edge-zones 9a24e83 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-openstack-serial 9a24e83 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 9a24e83 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-disruptive 9a24e83 link false /test e2e-aws-disruptive
ci/prow/okd-e2e-gcp 9a24e83 link false /test okd-e2e-gcp
ci/prow/e2e-vsphere-ovn-etcd-scaling 9a24e83 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 9a24e83 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-single-node-serial 9a24e83 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-azure-ovn-upgrade 9a24e83 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial-publicnet 9a24e83 link false /test e2e-aws-ovn-serial-publicnet
ci/prow/e2e-aws-ovn-etcd-scaling 9a24e83 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial 9a24e83 link false /test e2e-gcp-fips-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented May 16, 2025

Job Failure Risk Analysis for sha: 9a24e83

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback MissingData
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 50.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade IncompleteTests
Tests for this run (2071) are below the historical average (3213): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

@dfajmon
Copy link
Contributor Author

dfajmon commented May 20, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

Copy link
Contributor

openshift-ci bot commented May 20, 2025

@dfajmon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5c251f50-3583-11f0-8b62-d73dae1466f0-0

wangke19 pushed a commit to wangke19/origin that referenced this pull request Jun 9, 2025
@dfajmon dfajmon closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants