-
Notifications
You must be signed in to change notification settings - Fork 4.7k
test/extended: check if prometheus is firing a watchdog alert #22512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/extended: check if prometheus is firing a watchdog alert #22512
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Small nit, not sure whether it is important.
Let us know if you need a lgtm from our side. Not sure what the process is in this repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalmatze, mxinden, paulfantom, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
Checking if Watchdog alert is in firing state by querying prometheus metrics.
Based on
"should report telemetry if a cloud.openshift.com token is present"
test and on openshift/cluster-monitoring-operator#266 PR./cc @brancz @mxinden @s-urbaniak @squat @metalmatze