Skip to content

test/extended: check if prometheus is firing a watchdog alert #22512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulfantom
Copy link
Contributor

Checking if Watchdog alert is in firing state by querying prometheus metrics.

Based on "should report telemetry if a cloud.openshift.com token is present" test and on openshift/cluster-monitoring-operator#266 PR.

/cc @brancz @mxinden @s-urbaniak @squat @metalmatze

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2019
@paulfantom
Copy link
Contributor Author

/retest

Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Small nit, not sure whether it is important.

@mxinden
Copy link
Contributor

mxinden commented Apr 10, 2019

Let us know if you need a lgtm from our side. Not sure what the process is in this repository.

@squeed
Copy link
Contributor

squeed commented Apr 10, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@mxinden
Copy link
Contributor

mxinden commented Apr 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalmatze, mxinden, paulfantom, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3e176c9 into openshift:master Apr 10, 2019
@paulfantom paulfantom deleted the test_watchdog_alert branch April 11, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants