-
Notifications
You must be signed in to change notification settings - Fork 4.7k
images/tests/Dockerfile.rhel: Install jq #22378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't think awscli belongs. We'd have to add gcloud, azure cli, etc. CI tooling like that should be in a separate container within the installer pod. We don't ship those as RPMs in downstream either and can't keep pace. |
jq is in the same boat. |
jq will allow us to simplify the templating which landed in openshift/release@7e56379d0b (templates/openshift: grab bootstrap log on failure, 2019-01-14, openshift/release#2633).
Yeah, @abhinavdahiya was suggesting that I do something like what we currently do for the nested libvirt installer. That makes sense, so I've dropped
Why is this? The |
@wking: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
awscli
will allow us to add CI for user-provided infrastructure, as documented by openshift/installer@39a926a918 (openshift/installer#1408).jq
will allow us to simplify the templating which landed in openshift/release@7e56379d0b (openshift/release#2633).