OCPBUGS-57887: Update to Kubernetes v1.31.10 #2348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an old runtime like containerd 1.7, this message is not implemented and what we get here is an empty non-nil slice. Let's check the len of the slice instead. While we are there, let's just return false and no error. In the following commits we will wrap the error and we didn't find any more info to add here. Signed-off-by: Rodrigo Campos <[email protected]>
This makes it clear the error comes due to a user namespace configuration. Otherwise the error returned looks too generic and is not clear. Before this PR, the error was: Warning FailedCreatePodSandBox 1s kubelet Failed to create pod sandbox: the handler "" is not known Now it is: Warning FailedCreatePodSandBox 1s kubelet Failed to create pod sandbox: runtime does not support user namespaces Signed-off-by: Rodrigo Campos <[email protected]>
Most errors where already wrapped, but these were missing. Signed-off-by: Rodrigo Campos <[email protected]>
This reverts commit fd06dcd. The revert is not to make it a hard error again, this revert is needed to revert cleanly the commit that added this as an error in the first place. Signed-off-by: Rodrigo Campos <[email protected]>
…ort feature" This reverts commit 8597b34. I wrote in the Kubernetes documentation: In practice this means you need at least Linux 6.3, as tmpfs started supporting idmap mounts in that version. This is usually needed as several Kubernetes features use tmpfs (the service account token that is mounted by default uses a tmpfs, Secrets use a tmpfs, etc.) The check is wrong for several reasons: * Pods can use userns before 6.3, they will just need to be careful to not use a tmpfs (like a serviceaccount). MOST users will probably need 6.3, but it is possible to use earlier kernel versions. 5.19 probably works fine and with improvements in the runtime 5.12 can probably be supported too. * Several distros backport changes and the recommended way is usually to try the syscall instead of testing kernel versions. I expect support for simple fs like tmpfs will be backported in several distros, but with this check it can generate confusion. * Today a clear error is shown when the pod is created, so it's unlikely a user will not understand why it fails. * Returning an error if utilkernel fails to understand what kernel version is running is also too strict (as we are logging a warning even if it is not the expected version) * We are switching to enabled by default, which will log a warning on every user that runs on an older than 6.3 kernel, adding noise to the logs. For there reasons, let's just remove the hardcoded kernel version check. Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
I needed to wrap the error for debugging, let's just keep this as it is useful. Signed-off-by: Rodrigo Campos <[email protected]>
We don't build these tests for Windows, let's remove this skip. We should have never added that skip, we should have skipped the entire suite on Windows. Signed-off-by: Rodrigo Campos <[email protected]>
…tables Signed-off-by: Carlos Panato <[email protected]>
[release-1.31] [go] Bump images, dependencies and versions to go 1.23.9 and distroless iptables
…of-#130800-upstream-release-1.31 Automated cherry pick of kubernetes#130800: Fix unit tests on windows
…of-#131623-upstream-release-1.31 Automated cherry pick of kubernetes#131623: kubelet: userns: Improve errors returned to the user
…of-#130243-upstream-release-1.31 Automated cherry pick of kubernetes#130243: Revert userns kernel check
…ptables Signed-off-by: Carlos Panato <[email protected]>
[release-1.31] [go] Bump images, dependencies and versions to go 1.23.10 and distroless iptables
Kubernetes official release v1.31.10
openshift-ci-robot
added
backports/unvalidated-commits
|
@atiratree: This pull request references Jira Issue OCPBUGS-57887, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@atiratree: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atiratree The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
@atiratree: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.