Skip to content

Commit c9dbae7

Browse files
committed
pkg/kubelet/userns: Remove skip on windows
We don't build these tests for Windows, let's remove this skip. We should have never added that skip, we should have skipped the entire suite on Windows. Signed-off-by: Rodrigo Campos <[email protected]>
1 parent 2e0622b commit c9dbae7

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

pkg/kubelet/userns/userns_manager_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"errors"
2424
"fmt"
2525
"os"
26-
goruntime "runtime"
2726
"testing"
2827

2928
"github.com/stretchr/testify/assert"
@@ -292,7 +291,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
292291
runtimeUserns bool
293292
runtimeHandler string
294293
success bool
295-
skipOnWindows bool
296294
}{
297295
{
298296
name: "no user namespace",
@@ -326,7 +324,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
326324
expMode: runtimeapi.NamespaceMode_POD,
327325
runtimeUserns: true,
328326
success: true,
329-
skipOnWindows: true,
330327
},
331328
{
332329
name: "user namespace, but no runtime support",
@@ -351,10 +348,6 @@ func TestGetOrCreateUserNamespaceMappings(t *testing.T) {
351348

352349
for _, tc := range cases {
353350
t.Run(tc.name, func(t *testing.T) {
354-
if tc.skipOnWindows && goruntime.GOOS == "windows" {
355-
// TODO: remove skip once the failing test has been fixed.
356-
t.Skip("Skip failing test on Windows.")
357-
}
358351
// These tests will create the userns file, so use an existing podDir.
359352
testUserNsPodsManager := &testUserNsPodsManager{
360353
podDir: t.TempDir(),

0 commit comments

Comments
 (0)